RichardWilliams / MVC-NHibernate-Ninject

This combines MVC 4 with NHibernate and Ninject as a default start.
7 stars 5 forks source link

Unit Test Project #2

Open dmiyamasu opened 11 years ago

dmiyamasu commented 11 years ago

Great starter project! It has been really helpful in starting my web app.

One thing I would love to see added is a Test Project. I am not really sure how to integrate testing into the project with Ninject, Fluent NHibernate, etc.

RichardWilliams commented 11 years ago

thank you very much for your feedback :-) I've been meaning to do something towards the testing. I will see if I can get something started in the next couple of days. I have been super busy on other things the last couple of months. But I will see what I can do :-)

dmiyamasu commented 11 years ago

Awesome! Thanks for responding, Richard! Let me know if there is anything I can do to help.

On Wed, Jan 30, 2013 at 2:01 AM, RichardWilliams notifications@github.comwrote:

thank you very much for your feedback :-) I've been meaning to do something towards the testing. I will see if I can get something started in the next couple of days. I have been super busy on other things the last couple of months. But I will see what I can do :-)

— Reply to this email directly or view it on GitHubhttps://github.com/RichardWilliams/MVC-NHibernate-Ninject/issues/2#issuecomment-12856148.

RichardWilliams commented 10 years ago

Hey there, its been a long time since I looked at this project, I thought I would take a look again and damn I need to refresh myself on what I did. Any how I think I will take a look at adding a few more things. I have added log4net and also the first test project, but I am not happy with it, I need to think a little about the testing some more. The thing I am not happy with is the AutoMapViewResult, ok its returned from the ProductController Index action, but I am not sure its a good test what I have done, its probably ok, its testing that a view of the AutoMapViewResult is returned. I think I also need to test that the model that is setup in the view is also correct, but I think that test is already doing it. It could be that I just need to write a test for the AutoMapViewResult and there lies another issue for me is the Mapper.Map call. so I need to look into how to test that ExecuteResult method.

dmiyamasu commented 10 years ago

Hey Richard, this looks like a good start with the Moq tests. I am a noob when it comes to writing tests. I wish that I could help more! It sounds like your wheels are already turning about how to improve the tests to meet your satisfaction. Are there any specific questions I can help with?