Richardtok / pe

0 stars 0 forks source link

List funciton bug #5

Open Richardtok opened 1 year ago

Richardtok commented 1 year ago

image.png

image.png

as can bee seen both have chicken in it but recipe 1 is not diplayed in the list. User guide did not mention it being case sensitive

nus-pe-bot commented 1 year ago

Team's Response

We tested this out and we got the same output as you. Unfortunately, we forgot to convert the input to lowercase at certain functions. We accept this bug.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitive for ingredient

Screenshot 2023-04-14 at 16.32.06.png "Salt" and "salt" are unlikely to be different ingredients in real life and thus should not be case sensitive.


[original: nus-cs2113-AY2223S2/pe-interim#1852] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We forgot to take into consideration the case sensitiveness of the inputs while accepting ingredients. This is something we will fix in the future iterations of the product.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** It is worth noting that this could be a huge functional bug as case sensitivity is a common occurrence for users to use. If I inputted **Chicken** and **chicken** this would be regarded as two different things when it is the same thing. This would lead to a functional bug as users would be confused as to why when they added **Chicken** to a recipe and they input list **chicken**, the app would not display the available recipes with **Chicken** in it. This should not be a low.severity it should be a medium.severity at least.