RichiH / modbus_exporter

Exporter which retrieves stats from a modbus system and exports them via HTTP for Prometheus consumption.
Apache License 2.0
90 stars 44 forks source link

Implement exporter-toolkit (closes #37) #42

Closed DaAwesomeP closed 1 year ago

DaAwesomeP commented 1 year ago

This pull supersedes #37. This pull provides the following new features:

The different command line options are breaking changes. This shift should make maintaining the exporter and bringing in future exporter-toolkit features (usually without further breaking changes) much easier.

I also updated many references to the previous repo that this repo superseded (that original repo is now archived).

I completely removed -telemetry-listen-address because...it didn't seem to do anything? It would log this port to the console, but unless there is a global variable being referenced somewhere it didn't actually listen on that port if it was different from -modbus-listen-address. The exporter-toolkit allows for listening on multiple ports at once which would effectively provide this functionality.

cc @bastischubert , @fschlich, and @SuperQ from the other pull, feel free to ignore if no longer relevant.

SuperQ commented 1 year ago

Nice. I think we should first drop the vendor dir. It's an old pattern we don't need anymore.

SuperQ commented 1 year ago

I opened https://github.com/RichiH/modbus_exporter/pull/43 as a cleanup step to make this PR easier. Or feel free to include my changes here.

SuperQ commented 1 year ago

@DaAwesomeP can you rebase this now that we've dropped the /vendor dir?

DaAwesomeP commented 1 year ago

@DaAwesomeP can you rebase this now that we've dropped the /vendor dir?

@SuperQ working on this now!

DaAwesomeP commented 1 year ago

OK, I think this is good to go! Ready for review or merge.

DaAwesomeP commented 1 year ago

Seems legit, we'll need to get some CI set up here.

Hah! Yes, I agree! I would really love the automatic tag/release artifact bit too.