search

Richterrettich / rpm-rs

A pure rust library for building and parsing RPM's
Other
39 stars 18 forks source link

Read release into a String, do not require it to be u16 first #34

Closed wzzrd closed 2 years ago

wzzrd commented 3 years ago 
Many RPM based Linux distributions use release tags like '1.fc33'
instead of just '1'. The current implementation, with release being read
as a u16 seems to make using release tags like '1.fc33' impossible.

This change makes release() into a generic function, that accepts types
that implement the ToString trait, hence as I understand it (I'm quite
new to rust), both String and various numerical types like u16 should be
accepted, changing as little as possible of the existing API.

I'm primarily pushing this change because I want to be able to use
'1.fc33' style release tags with the generate-rpm crate, which is based
on rpm-rs.
wzzrd commented 3 years ago

Polite ping... :)

wzzrd commented 3 years ago

Has this repo been abandoned?

wzzrd commented 3 years ago

Bumping this one last time...

drahnr commented 2 years ago

@wzzrd I'll collect the changes to my fork and upstream back here once activity picks up again

dacut commented 2 years ago

I have merged this into a fork since this seems to be abandoned for now. https://docs.rs/kanga-rpm-rs/0.7.0/rpm/

Richterrettich commented 2 years ago

hi,

sorry for the absence, I will review all PR's this weekend and pick up development the upcoming weeks

wzzrd commented 2 years ago

Yay!