search

Richterrettich / rpm-rs

A pure rust library for building and parsing RPM's
Other
39 stars 19 forks source link

Refactor code to follow rust idioms better #8

Closed dralley closed 4 years ago

dralley commented 4 years ago

Fixed some things suggested by cargo clippy

Moved some tests around to follow the standard test organization https://doc.rust-lang.org/book/ch11-03-test-organization.html

Added a lib.rs file

Richterrettich commented 4 years ago

Hi and thanks for the PR! I'll have a look

Richterrettich commented 4 years ago

I think standardizing the project layout is a good thing and I want to merge your changes as soon as my findings are resolved. I have to coordinate this with #4 though.

dralley commented 4 years ago

Hi -- sorry about the missing file, it was done right in a previous commit and I decided to re-do it and must have missed it.

Totally understand w/ the other PR. Mine is probably easier to rebase and I'm fine with doing so when theirs is finished.

Richterrettich commented 4 years ago

So, #4 got merged. I'm open for your PR now.

drahnr commented 4 years ago

@dralley I am sorry that a lot of things got shifted a bit as part of #4, if this becomes too frustrating please ping me, and then let's see how to get this accross the finishline :)

dralley commented 4 years ago

No problem. I'm going to reduce the scope of the PR a bit though. Creating lib.rs and moving the tests around required changing visibility of things and adjusting the API in ways that I don't really feel comfortable doing as a drive-by contributor.

(also I just don't have as much time at the moment)

dralley commented 4 years ago

I'm done with this for now FYI. Feel free to go ahead and merge it as-is. If I come back to it eventually I'll just make a new PR.

Richterrettich commented 4 years ago

This looks good to me.