Update ViewEmail.php - Githubissues

RickDBCN / filament-email

Log emails in your Filament project

https://filament-email-demo.marcogermani.it/

MIT License

77 stars 23 forks source link

Update ViewEmail.php #45

Closed marcogermani87 closed 4 months ago

marcogermani87 commented 4 months ago

Autoload custom Resource from config

what-the-diff[bot] commented 4 months ago

PR Summary :tada:

Improved Resource Retrieval in ViewEmail.php File :wrench: The getResource() method has been updated. Now, it smoothly gets values from a configuration option named filament-email.resource.class. And guess what? If that option isn't set, it doesn't panic :sweat_smile: Instead, it confidently falls back on a plan B, using EmailResource::class. This change enhances flexibility and increases resilience. :thumbsup:

RickDBCN commented 4 months ago

Thanks!

marcogermani87 commented 4 months ago

Thanks!

Hi Rick, i've made some interesting changes on my fork (https://github.com/marcogermani87/filament-email/):

Loading plugin throgh ::make() method
Table and form view rework
Advanced search for created_at field (From/To date)
Added translations support (EN/IT for now)
Confirm modal for re-send e-mail action
Scoped filter for Email model for enhance table free search

Take a look and if you agree i can make a PR for this changes.

Regards.

RickDBCN commented 4 months ago

Thanks!

Hi Rick, i've made some interesting changes on my fork (https://github.com/marcogermani87/filament-email/):
* Loading plugin throgh ::make() method

* Table and form view rework

* Advanced search for created_at field (From/To date)

* Added translations support (EN/IT for now)

* Confirm modal for re-send e-mail action

* Scoped filter for Email model for enhance table free search
Take a look and if you agree i can make a PR for this changes.

Regards.

Hi Marco! Great work! :) Could you make a PR for these changes? Would be highly appreciated.

Can you update the screenshots to English?

Many thanks!

marcogermani87 commented 4 months ago

Thanks!

Hi Rick, i've made some interesting changes on my fork (https://github.com/marcogermani87/filament-email/):
* Loading plugin throgh ::make() method

* Table and form view rework

* Advanced search for created_at field (From/To date)

* Added translations support (EN/IT for now)

* Confirm modal for re-send e-mail action

* Scoped filter for Email model for enhance table free search
Take a look and if you agree i can make a PR for this changes. Regards.
Hi Marco! Great work! :) Could you make a PR for these changes? Would be highly appreciated.

Can you update the screenshots to English?

Many thanks!

Yes, sure! I'll try to do this tonight.