RickStrahl / MarkdownMonster

An extensible Markdown Editor, Viewer and Weblog Publisher for Windows
https://markdownmonster.west-wind.com
Other
1.57k stars 236 forks source link

Please add a spell checker #64

Closed ArthurZ closed 7 years ago

ArthurZ commented 7 years ago

It would be nice to have an integrated spell checker.

Thanks!

RickStrahl commented 7 years ago

Not sure what you're asking. Spell checking is built-in via underlining misspelled text and selection.

image

ArthurZ commented 7 years ago

I ensured the SpellChecker was set to True. Misspelling a word does not work like in your case for me: spellcheckerdoesntwork

RickStrahl commented 7 years ago

True is not a valid value. Valid value is true. You can also click on the check icon in the Window header to toggle the spell checker.

image

ArthurZ commented 7 years ago

Yes, sorry, it was "EditorEnableSpellcheck": true, And toggling the mark above has no effect on anything.

RickStrahl commented 7 years ago

Not sure then.

What version of Windows and Internet Explorer are you running on? What language? And did you change dictionaries by any chance? Make sure dictionaries used exist in the Editor folder

ArthurZ commented 7 years ago

Win 7 Pro 64 Bit IE 11. American English The US dictionary exists among others: http://screencast.com/t/wGSl8j7Ys

RickStrahl commented 7 years ago

Yeah I'm really not sure why it's not working.

Can you do the following:

What if any error messages pop up on the bottom of the editor area? You're looking for errors that might relate to spell checking (some messages are OK).

When done reverse these steps.

ArthurZ commented 7 years ago

Whoa I do not have editorsettings.json Is that the problem? These are the files http://screencast.com/t/wGSl8j7Ys But now I think may be it is the .js file, not json?

RickStrahl commented 7 years ago

Sorry editorsettings.js... It's there. Changed the message above (in case somebody searches for this).

ArthurZ commented 7 years ago

OK, did that. Edited to set it to true, started MM. Put in some garbled text and no messages, no spell checking. Nada. Besides, I noticed, or it may by a deception, the SpellCheck toggle button is never becoming bright/active.

RickStrahl commented 7 years ago

No error messages on the bottom of the editor screen.

Sorry I'm out of ideas on why this wouldn't work especially if there are no errors.

You can also rename your %appdata%\Markdown Monster\MarkdownMonster.json file and let a new one be created when you start up again. Shut down MM, rename the file, then restart (which should create a new file with all the stock defaults). Does that work any better?

The only other thing I can think of is, uninstall completely and resinstall to make sure all the right files are there.

I haven't heard this from anybody else so this seems to be something specific to your setup, but I just can't think of what that could be.

ArthurZ commented 7 years ago

I saw MarkdownMonster.json in C:\Users\me\AppData\Roaming\Markdown Monster Anyways deleted it. It re-appeared. But did not heal the SpellChecker. I will un-install on next MM version release.

RickStrahl commented 7 years ago

1.0.22 is available now.

To do a complete uninstall reinstall:

I have a feeling this won't help in your case, but worth a try.

One more thing I thought of here. It might be that there's some sort of permission problem or perhaps AV blocking some functionality. Maybe double check and make sure that AV isn't interfering by excluding MM folder. MM uses HUnspell which initially gave me a number of issues with various AV software until I switched to a different version. Perhaps AV is flagging that somehow or you might still have that older version around.

IAC, I'm at the end of my line with why this isn't working. I haven't heard this from anybody else, so I assume this is not a common problem.

follow up: Ran into another user who reported slow spell checking operation and it turned out this was due to their AV software interfering. Not sure why - but they reported excluding folder made unbearably slow spell checking work fast as it should.

ArthurZ commented 7 years ago

Appreciate your efforts Rick. Unfortunately, no candle. Did exactly that in process discovered Chrome had a handle to Program Files/Markdown Monster. Removed. Re-installed. A deep sigh. Checked the AV pointers. Can't agree because I have ESET on my work machine, and ESET on my personal to which I installed the same (latest) MM and the SpellChecker works there. The difference is Win 10 Home vs. Win 7 Pro.

RickStrahl commented 7 years ago

Hmmm... Can you just try to turn off ESET on the Win7 machine temporarily and see if that changes anything?

I don't think that Win7 should have any issues with MM. If there was a problem I'd suspect it to be affecting everything and not just the spell checker of all things. I'll see if I can set up a Win7 VM on Azure and see if anything comes up there.

ArthurZ commented 7 years ago

I did disabled it completely, does not help.

RickStrahl commented 7 years ago

So I set up an Azure Win7 VM and I was able to confirm the problem you describe - the spellchecker is not turning on. As a matter of fact a whole bunch of stuff is not working like theming of the editor and font settings etc - basically all the configuration settings are not being passed to the editor.

I believe this was broken when I added DPI awareness to the browser which didn't actually work with Windows 7. I traced this to the routine that updates the 'theme' and settings and uses DPI detection code to adjust the browser DPI settings. Anything prior to Win8.1 didn't have these DPI check routines available and so they fail. Fixed by wrapping around exception handler.

Thanks for your patience with this!

4f4a4f25bbc20506838cb4d3a9659235730a0c0c

I'll get this into an update shortly - 1.0.23.1 most likely.

RickStrahl commented 7 years ago

Did this fix the spell checker problem?

ArthurZ commented 7 years ago

Yes, it did! I am a happy man again. Thank you very much!