search

RickStrahl / Westwind.AspnetCore.LiveReload

ASP.NET Core Live Reload Middleware that monitors file changes in your project and automatically reloads the browser's active page
Other
469 stars 42 forks source link

Script injection fails when body tag is not lowercase #10

Closed 4nonym0us closed 5 years ago

4nonym0us commented 5 years ago

Was skim reading the sources and found a tiny bug at the following line: https://github.com/RickStrahl/Westwind.AspnetCore.LiveReload/blob/4e120899751b3050695112394d674fad54f423ad/Westwind.AspnetCore.LiveReload/WebsocketScriptInjectionHelper.cs#L39 This replacement assumes that body tag is always lowercase (https://github.com/RickStrahl/Westwind.AspnetCore.LiveReload/blob/master/Westwind.AspnetCore.LiveReload/WebsocketScriptInjectionHelper.cs#L20), but HTML spec doesn't have such restriction.

4nonym0us commented 5 years ago

Looks like that method is obsolete as it's never used.