Rickaym / manim-sideview

A Manim utility extension for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=Rickaym.manim-sideview
MIT License
101 stars 11 forks source link

performance issues #66

Open Rickaym opened 1 year ago

Rickaym commented 1 year ago

Starting to run manim-sideview is painstakingly slow. The codebase it runs on is also in very bad health.

This happens for these reasons:

Potential Solution:

  1. Rather than spawning a non-shell child_processes connected to a Pseudo Terminal for execution, we can use the VSCode integrated terminal. The initial reason why the Pseudo Terminal + child_process was chosen was due to the lack of transparency the integrated terminal has on the commands running on it, that is, it is not straight forward to detect whether the render has completed, failed, or is ongoing. Furthermore, it does not give the extension access to see the logs generated by the command processes, which makes the extension be unable to figure out the output file type from the logs like normally. Perhaps there is a workaround to this.

Progress:

[-] Code Refactors