Closed mikebarkmin closed 1 year ago
Is the lack of a profile associated with the extension or is it the manim framework itself?
I think the limitation is with this extension. Especially with the way the extension builds the output path.
Because the quality is assumed based on the provided pixel width and height. https://github.com/Rickaym/manim-sideview/blob/bed6141614faef6803d686247cf04d2a95f89718/src/globals.ts#L89
For a portrait video 1080x1920 there is no key in the quality map, because 1920p60 does not exist here: https://github.com/Rickaym/manim-sideview/blob/bed6141614faef6803d686247cf04d2a95f89718/assets/local/manim.cfg.json#L8
My pull-request fixes the issue #70
Looks good to me, I will merge that and release it alongside other performance updates in the coming week.
Thanks.
Reopened to close along with the release.
Occasionally, I want to render a YouTube Short video. For this, a need the following custom manim.cfg
Unfortunately, I think there is no profile on the quality_map for this. Maybe consider adding options for portrait videos.