Rickaym / manim-sideview

A Manim utility extension for Visual Studio Code.
https://marketplace.visualstudio.com/items?itemName=Rickaym.manim-sideview
MIT License
113 stars 11 forks source link

Support portrait mode #69

Closed mikebarkmin closed 1 year ago

mikebarkmin commented 1 year ago

Occasionally, I want to render a YouTube Short video. For this, a need the following custom manim.cfg

[CLI]
pixel_width  = 1080
pixel_height = 1920

Unfortunately, I think there is no profile on the quality_map for this. Maybe consider adding options for portrait videos.

Rickaym commented 1 year ago

Is the lack of a profile associated with the extension or is it the manim framework itself?

mikebarkmin commented 1 year ago

I think the limitation is with this extension. Especially with the way the extension builds the output path.

mikebarkmin commented 1 year ago

Because the quality is assumed based on the provided pixel width and height. https://github.com/Rickaym/manim-sideview/blob/bed6141614faef6803d686247cf04d2a95f89718/src/globals.ts#L89

For a portrait video 1080x1920 there is no key in the quality map, because 1920p60 does not exist here: https://github.com/Rickaym/manim-sideview/blob/bed6141614faef6803d686247cf04d2a95f89718/assets/local/manim.cfg.json#L8

mikebarkmin commented 1 year ago

My pull-request fixes the issue #70

Rickaym commented 1 year ago

Looks good to me, I will merge that and release it alongside other performance updates in the coming week.

Thanks.

Rickaym commented 1 year ago

Reopened to close along with the release.

Rickaym commented 1 year ago

7ee1ca5