yanick76
commented
4 years ago I think this is off-topic issue because source of this issue is not related to this project. Anyway, your problem is you are trying to process asynchronous data synchronously. Sample is sufficient for 1 controller but no for 3.
Btw, your modifications like in OpenProtocolDriver constructor:
typeof(Mid0002), //Added by meare not necessary because this list of MIDs to parse. MID 0002 (EDIT: sorry, I mean MID 0001, MID 0002 is response and this change is ok) is "your" MID meaning this is something you sent to controller and in this case it's not necassary parse it.
I sligtly modified your code to work with 3 controllers: (sorry, I can't attach it to this comment because " Something went really wrong, and we can’t process that file." and I don't know why)
using OpenProtocolInterpreter.Sample.Driver;
using OpenProtocolInterpreter.Sample.Driver.Events;
using System;
using System.Windows.Forms;
using OpenProtocolInterpreter.Sample.Driver.Helpers;
using OpenProtocolInterpreter.KeepAlive;
using System.Drawing;
using OpenProtocolInterpreter.Tightening;
using OpenProtocolInterpreter.Communication;
using OpenProtocolInterpreter.Job;
using OpenProtocolInterpreter.Sample.Driver.Commands;
using System.Threading.Tasks;
using OpenProtocolInterpreter.Sample.Ethernet;
using Timer = System.Threading.Timer;
namespace OpenProtocolInterpreter.Sample
{
public partial class DriverForm : Form
{
private Timer keepAliveTimerPort1, keepAliveTimerPort2, keepAliveTimerPort3;
private OpenProtocolDriver driverPort1, driverPort2, driverPort3;
private string IP1, IP2, IP3;
private int port1, port2, port3;
public DriverForm()
{
InitializeComponent();
keepAliveTimerPort1 = new System.Threading.Timer(KeepAliveTimerPort1_Elapsed, null, System.Threading.Timeout.Infinite, System.Threading.Timeout.Infinite);
keepAliveTimerPort2 = new System.Threading.Timer(KeepAliveTimerPort2_Elapsed, null, System.Threading.Timeout.Infinite, System.Threading.Timeout.Infinite);
keepAliveTimerPort3 = new System.Threading.Timer(KeepAliveTimerPort3_Elapsed, null, System.Threading.Timeout.Infinite, System.Threading.Timeout.Infinite);
}
private void KeepAliveTimerPort1_Elapsed(object sender)
{
if (driverPort1.KeepAlive.ElapsedMilliseconds > 10000) //10 sec
{
Log.Information($"Sending Keep Alive For Port 9001...");
var pack = driverPort1.SendAndWaitForResponse(new Mid9999().Pack(), TimeSpan.FromSeconds(10));
if (pack != null && pack.HeaderData.Mid == Mid9999.MID)
{
lastMessageArrived.Text = Mid9999.MID.ToString();
Log.Information($"Keep Alive Received For Port 9001 - Pack {pack}");
}
else
{
Log.Information($"Keep Alive Not Received For Port 9001");
}
}
}
private void KeepAliveTimerPort2_Elapsed(object sender)
{
if (driverPort2.KeepAlive.ElapsedMilliseconds > 10000) //10 sec
{
Log.Information($"Sending Keep Alive For Port 9002...");
var pack = driverPort2.SendAndWaitForResponse(new Mid9999().Pack(), TimeSpan.FromSeconds(10));
if (pack != null && pack.HeaderData.Mid == Mid9999.MID)
{
lastMessageArrived.Text = Mid9999.MID.ToString();
Log.Information($"Keep Alive Received For Port 9002- Pack {pack}");
}
else
{
Log.Information($"Keep Alive Not Received For Port 9002");
}
}
}
private void KeepAliveTimerPort3_Elapsed(object sender)
{
if (driverPort3.KeepAlive.ElapsedMilliseconds > 10000) //10 sec
{
Log.Information($"Sending Keep Alive For Port 9003...");
var pack = driverPort3.SendAndWaitForResponse(new Mid9999().Pack(), TimeSpan.FromSeconds(10));
if (pack != null && pack.HeaderData.Mid == Mid9999.MID)
{
lastMessageArrived.Text = Mid9999.MID.ToString();
Log.Information($"Keep Alive Received For Port 9003 - Pack {pack}");
}
else
{
Log.Information($"Keep Alive Not Received For Port 9003");
}
}
}
private void BtnConnection_Click(object sender, EventArgs e)
{
//Added list of mids i want to use in my interpreter, every another will be desconsidered
driverPort1 = new OpenProtocolDriver(new Type[]
{
typeof(Mid0001),
typeof(Mid0002), //Added by me
typeof(Mid0005),
typeof(Mid0004),
typeof(Mid0003),
typeof(ParameterSet.Mid0010), //Added by me
typeof(ParameterSet.Mid0011),
typeof(ParameterSet.Mid0013),
typeof(Mid0035),
typeof(Mid0031),
typeof(Alarm.Mid0071),
typeof(Alarm.Mid0074),
typeof(Alarm.Mid0076),
typeof(Vin.Mid0052),
typeof(Mid0061),
typeof(Mid0062),//added by me
typeof(Mid0065),
typeof(Time.Mid0081),
typeof(Mid9999)
});
Log.Information($"Communicating to Port 9001");
SimpleTcpClient client1 = null;
Task.Run(() =>
{
client1 = new Ethernet.SimpleTcpClient().Connect(IP1, port1);
if (driverPort1.BeginCommunication(client1))
{
keepAliveTimerPort1.Change(2000, 2000);
this.Invoke(new Action(() =>
{
connectionStatus.Text = "Connected!";
connectionStatus.BackColor = Color.Green;
}));
Log.Information($"Connected to Port 9001");
}
else
{
driverPort1 = null;
this.Invoke(new Action(() =>
{
connectionStatus.Text = "Disconnected!";
connectionStatus.BackColor = Color.Red;
}));
Log.Information($"DisConnected to Port 9001");
}
});
//for Port 2
driverPort2 = new OpenProtocolDriver(new Type[]
{
typeof(Mid0001),
typeof(Mid0002), //Added by me
typeof(Mid0005),
typeof(Mid0004),
typeof(Mid0003),
typeof(ParameterSet.Mid0010), //Added by me
typeof(ParameterSet.Mid0011),
typeof(ParameterSet.Mid0013),
typeof(Mid0035),
typeof(Mid0031),
typeof(Alarm.Mid0071),
typeof(Alarm.Mid0074),
typeof(Alarm.Mid0076),
typeof(Vin.Mid0052),
typeof(Mid0061),
typeof(Mid0062),//added by me
typeof(Mid0065),
typeof(Time.Mid0081),
typeof(Mid9999)
});
Log.Information($"Communicating to Port 9002");
SimpleTcpClient client2 = null;
Task.Run(() =>
{
client2 = new Ethernet.SimpleTcpClient().Connect(IP2, port2);
if (driverPort2.BeginCommunication(client2))
{
keepAliveTimerPort2.Change(2000, 2000);
//connectionStatus.Text = "Connected!";
//connectionStatus.BackColor = Color.Green;
Log.Information($"Connected to Port 9002");
}
else
{
driverPort2 = null;
//connectionStatus.Text = "Disconnected!";
//connectionStatus.BackColor = Color.Red;
Log.Information($"DisConnected to Port 9002");
}
});
//for Port 3
driverPort3 = new OpenProtocolDriver(new Type[]
{
typeof(Mid0001),
typeof(Mid0002), //Added by me
typeof(Mid0005),
typeof(Mid0004),
typeof(Mid0003),
typeof(ParameterSet.Mid0010), //Added by me
typeof(ParameterSet.Mid0011),
typeof(ParameterSet.Mid0013),
typeof(Mid0035),
typeof(Mid0031),
typeof(Alarm.Mid0071),
typeof(Alarm.Mid0074),
typeof(Alarm.Mid0076),
typeof(Vin.Mid0052),
typeof(Mid0061),
typeof(Mid0062),//added by me
typeof(Mid0065),
typeof(Time.Mid0081),
typeof(Mid9999)
});
Log.Information($"Communicating to Port 9003");
SimpleTcpClient client3 = null;
Task.Run(() =>
{
client3 = new Ethernet.SimpleTcpClient().Connect(IP3, port3);
if (driverPort3.BeginCommunication(client3))
{
keepAliveTimerPort3.Change(2000, 2000);
//connectionStatus.Text = "Connected!";
//connectionStatus.BackColor = Color.Green;
Log.Information($"Connected to Port 9003");
}
else
{
driverPort3 = null;
//connectionStatus.Text = "Disconnected!";
//connectionStatus.BackColor = Color.Red;
Log.Information($"DisConnected to Port 9003");
}
});
}
/// <summary>
/// Job info subscribe
/// </summary>
/// <param name="sender"></param>
/// <param name="e"></param>
private void BtnJobInfoSubscribe_Click(object sender, EventArgs e)
{
Log.Information($"Sending Job Info Subscribe...");
var pack = driverPort1.SendAndWaitForResponse(new Mid0034().Pack(), TimeSpan.FromSeconds(10));
if (pack != null)
{
if (pack.HeaderData.Mid == Mid0004.MID)
{
var mid04 = pack as Mid0004;
Log.Information($@"Error while subscribing (MID 0004):
Error Code: <{mid04.ErrorCode}>
Failed MID: <{mid04.FailedMid}>");
}
else
Log.Information($"Job Info Subscribe accepted!");
}
driverPort1.AddUpdateOnReceivedCommand(typeof(Mid0035), OnJobInfoReceived);
}
/// <summary>
/// Tightening subscribe
/// </summary>
/// <param name="sender"></param>
/// <param name="e"></param>
private void BtnTighteningSubscribe_Click(object sender, EventArgs e)
{
Log.Information($"Sending Tightening Subscribe For Port 9001...");
// var pack = driver.SendAndWaitForResponse(new Mid0060().Pack(), TimeSpan.FromSeconds(10));
/*changing default revision no from 7 to 1*/
int Revision = txtRevision.Text.Trim() == "" ? 1 : int.Parse(txtRevision.Text.Trim());
var pack = driverPort1.SendAndWaitForResponse(new Mid0060(Revision).Pack(), TimeSpan.FromSeconds(10));
if (pack != null)
{
if (pack.HeaderData.Mid == Mid0004.MID)
{
var mid04 = pack as Mid0004;
Log.Information($@"Error while subscribing (MID 0004):
Error Code: <{mid04.ErrorCode}>
Failed MID: <{mid04.FailedMid}>");
}
else
{
Log.Information($"Tightening Subscribe accepted!");
lblManualMidResult.Text = $"Tightening Response:{pack.HeaderData}";
}
}
//register command
driverPort1.AddUpdateOnReceivedCommand(typeof(Mid0061), OnTighteningReceived1);
//Port2
Log.Information($"Sending Tightening Subscribe For Port 9002...");
// var pack = driver.SendAndWaitForResponse(new Mid0060().Pack(), TimeSpan.FromSeconds(10));
/*changing default revision no from 7 to 1*/
var pack2 = driverPort2.SendAndWaitForResponse(new Mid0060(1).Pack(), TimeSpan.FromSeconds(10));
// var pack = driver.SendAndWaitForResponse(new ParameterSet.Mid0010(Revision).Pack(), TimeSpan.FromSeconds(10));
if (pack2 != null)
{
if (pack2.HeaderData.Mid == Mid0004.MID)
{
var mid04 = pack2 as Mid0004;
Log.Information($@"Error while subscribing (MID 0004):
Error Code: <{mid04.ErrorCode}>
Failed MID: <{mid04.FailedMid}>");
}
else
{
Log.Information($"Tightening Subscribe accepted!");
lblManualMidResult.Text = $"Tightening Response:{pack.HeaderData}";
}
}
//register command
driverPort2.AddUpdateOnReceivedCommand(typeof(Mid0061), OnTighteningReceived2);
//Port3
Log.Information($"Sending Tightening Subscribe For Port 9003...");
// var pack = driver.SendAndWaitForResponse(new Mid0060().Pack(), TimeSpan.FromSeconds(10));
/*changing default revision no from 7 to 1*/
var pack3 = driverPort3.SendAndWaitForResponse(new Mid0060(1).Pack(), TimeSpan.FromSeconds(10));
// var pack = driver.SendAndWaitForResponse(new ParameterSet.Mid0010(Revision).Pack(), TimeSpan.FromSeconds(10));
if (pack3 != null)
{
if (pack3.HeaderData.Mid == Mid0004.MID)
{
var mid04 = pack3 as Mid0004;
Log.Information($@"Error while subscribing (MID 0004):
Error Code: <{mid04.ErrorCode}>
Failed MID: <{mid04.FailedMid}>");
}
else
{
Log.Information($"Tightening Subscribe accepted!");
lblManualMidResult.Text = $"Tightening Response:{pack.HeaderData}";
}
}
//register command
driverPort3.AddUpdateOnReceivedCommand(typeof(Mid0061), OnTighteningReceived3);
}
private void BtnSendJob_Click(object sender, EventArgs e)
{
new SendJobCommand(driverPort1).Execute((int)numericJob.Value);
}
/// <summary>
/// Async method from controller, MID 0035 (Job Info)
/// </summary>
/// <param name="e"></param>
private void OnJobInfoReceived(MIDIncome e)
{
driverPort1.SendMessage(e.Mid.BuildAckPackage());
var jobInfo = e.Mid as Mid0035;
lastMessageArrived.Text = Mid0035.MID.ToString();
Log.Information($@"JOB INFO RECEIVED (MID 0035):
Job ID: <{jobInfo.JobId}>
Job Status: <{(int)jobInfo.JobStatus}> ({jobInfo.JobStatus.ToString()})
Job Batch Mode: <{(int)jobInfo.JobBatchMode}> ({jobInfo.JobBatchMode.ToString()})
Job Batch Size: <{jobInfo.JobBatchSize}>
Job Batch Counter: <{jobInfo.JobBatchCounter}>
TimeStamp: <{jobInfo.TimeStamp.ToString("yyyy-MM-dd:HH:mm:ss")}>");
}
/// <summary>
/// Async method from controller, MID 0061 (Last Tightening)
/// Basically, on every tightening this method will be called!
/// </summary>
/// <param name="e"></param>
private void OnTighteningReceived1(MIDIncome e)
{
Log.Information("Tightening Data Received For Port 9001");
// lblManualMidResult.Text = "Tightening Data Received";
driverPort1.SendMessage(e.Mid.BuildAckPackage());
var tighteningMid = e.Mid as Mid0061;
lastMessageArrived.Text = Mid0061.MID.ToString();
Log.Information($@"TIGHTENING RECEIVED For Port 9001 (MID 0061):
Cell ID: <{tighteningMid.CellId}>
Channel ID: <{tighteningMid.ChannelId}>
Torque Controller Name: <{tighteningMid.TorqueControllerName}>
VIN Number: <{tighteningMid.VinNumber}>
Job ID: <{tighteningMid.JobId}>
Parameter Set ID: <{tighteningMid.ParameterSetId}>
Batch Size: <{tighteningMid.BatchSize}>
Batch Counter: <{tighteningMid.BatchCounter}>
Tightening Status: <{tighteningMid.TighteningStatus}>
Torque Status: <{(int)tighteningMid.TorqueStatus}> ({tighteningMid.TorqueStatus.ToString()})
Angle Status: <{(int)tighteningMid.AngleStatus}> ({tighteningMid.AngleStatus.ToString()})
Torque Min Limit: <{tighteningMid.TorqueMinLimit}>
Torque Max Limit: <{tighteningMid.TorqueMaxLimit}>
Torque Final Target: <{tighteningMid.TorqueFinalTarget}>
Torque: <{tighteningMid.Torque}>
Angle Min Limit: <{tighteningMid.AngleMinLimit}>
Angle Max Limit: <{tighteningMid.AngleMaxLimit}>
Final Angle Target: <{tighteningMid.AngleFinalTarget}>
Angle: <{tighteningMid.Angle}>
TimeStamp: <{tighteningMid.Timestamp.ToString("yyyy-MM-dd:HH:mm:ss")}>
Last Change In Parameter Set: <{tighteningMid.LastChangeInParameterSet.ToString("yyyy-MM-dd:HH:mm:ss")}>
Batch Status: <{(int)tighteningMid.BatchStatus}> ({tighteningMid.BatchStatus.ToString()})
TighteningID: <{tighteningMid.TighteningId}>");
}
private void OnTighteningReceived2(MIDIncome e)
{
Log.Information("Tightening Data Received For Port 9002");
// lblManualMidResult.Text = "Tightening Data Received";
driverPort2.SendMessage(e.Mid.BuildAckPackage());
var tighteningMid = e.Mid as Mid0061;
lastMessageArrived.Text = Mid0061.MID.ToString();
Log.Information($@"TIGHTENING RECEIVED For Port 9002 (MID 0061):
Cell ID: <{tighteningMid.CellId}>
Channel ID: <{tighteningMid.ChannelId}>
Torque Controller Name: <{tighteningMid.TorqueControllerName}>
VIN Number: <{tighteningMid.VinNumber}>
Job ID: <{tighteningMid.JobId}>
Parameter Set ID: <{tighteningMid.ParameterSetId}>
Batch Size: <{tighteningMid.BatchSize}>
Batch Counter: <{tighteningMid.BatchCounter}>
Tightening Status: <{tighteningMid.TighteningStatus}>
Torque Status: <{(int)tighteningMid.TorqueStatus}> ({tighteningMid.TorqueStatus.ToString()})
Angle Status: <{(int)tighteningMid.AngleStatus}> ({tighteningMid.AngleStatus.ToString()})
Torque Min Limit: <{tighteningMid.TorqueMinLimit}>
Torque Max Limit: <{tighteningMid.TorqueMaxLimit}>
Torque Final Target: <{tighteningMid.TorqueFinalTarget}>
Torque: <{tighteningMid.Torque}>
Angle Min Limit: <{tighteningMid.AngleMinLimit}>
Angle Max Limit: <{tighteningMid.AngleMaxLimit}>
Final Angle Target: <{tighteningMid.AngleFinalTarget}>
Angle: <{tighteningMid.Angle}>
TimeStamp: <{tighteningMid.Timestamp.ToString("yyyy-MM-dd:HH:mm:ss")}>
Last Change In Parameter Set: <{tighteningMid.LastChangeInParameterSet.ToString("yyyy-MM-dd:HH:mm:ss")}>
Batch Status: <{(int)tighteningMid.BatchStatus}> ({tighteningMid.BatchStatus.ToString()})
TighteningID: <{tighteningMid.TighteningId}>");
}
private void OnTighteningReceived3(MIDIncome e)
{
Log.Information("Tightening Data Received For Port 9003");
// lblManualMidResult.Text = "Tightening Data Received";
driverPort3.SendMessage(e.Mid.BuildAckPackage());
var tighteningMid = e.Mid as Mid0061;
lastMessageArrived.Text = Mid0061.MID.ToString();
Log.Information($@"TIGHTENING RECEIVED For Port 9003 (MID 0061):
Cell ID: <{tighteningMid.CellId}>
Channel ID: <{tighteningMid.ChannelId}>
Torque Controller Name: <{tighteningMid.TorqueControllerName}>
VIN Number: <{tighteningMid.VinNumber}>
Job ID: <{tighteningMid.JobId}>
Parameter Set ID: <{tighteningMid.ParameterSetId}>
Batch Size: <{tighteningMid.BatchSize}>
Batch Counter: <{tighteningMid.BatchCounter}>
Tightening Status: <{tighteningMid.TighteningStatus}>
Torque Status: <{(int)tighteningMid.TorqueStatus}> ({tighteningMid.TorqueStatus.ToString()})
Angle Status: <{(int)tighteningMid.AngleStatus}> ({tighteningMid.AngleStatus.ToString()})
Torque Min Limit: <{tighteningMid.TorqueMinLimit}>
Torque Max Limit: <{tighteningMid.TorqueMaxLimit}>
Torque Final Target: <{tighteningMid.TorqueFinalTarget}>
Torque: <{tighteningMid.Torque}>
Angle Min Limit: <{tighteningMid.AngleMinLimit}>
Angle Max Limit: <{tighteningMid.AngleMaxLimit}>
Final Angle Target: <{tighteningMid.AngleFinalTarget}>
Angle: <{tighteningMid.Angle}>
TimeStamp: <{tighteningMid.Timestamp.ToString("yyyy-MM-dd:HH:mm:ss")}>
Last Change In Parameter Set: <{tighteningMid.LastChangeInParameterSet.ToString("yyyy-MM-dd:HH:mm:ss")}>
Batch Status: <{(int)tighteningMid.BatchStatus}> ({tighteningMid.BatchStatus.ToString()})
TighteningID: <{tighteningMid.TighteningId}>");
}
private void BtnSendProduct_Click(object sender, EventArgs e)
{
new DownloadProductCommand(driverPort1).Execute(txtProduct.Text);
}
private void BtnAbortJob_Click(object sender, EventArgs e)
{
new AbortJobCommand(driverPort1).Execute();
}
private void DriverForm_Load(object sender, EventArgs e)
{
Log.Information("App started");
}
private void btnManualMid_Click(object sender, EventArgs e)
{
Log.Information($"Sending Manual Mid...");
lblManualMidResult.Text = $"Sending {txtManualMid.Text}";
var pack = driverPort1.SendAndWaitForResponse(txtManualMid.Text.Trim(), TimeSpan.FromSeconds(10));
lblManualMidResult.Text = $"Response {pack}";
if (pack != null)
{
if (pack.HeaderData.Mid == Mid0004.MID)
{
var mid04 = pack as Mid0004;
Log.Information($@"Error while subscribing (MID 0004):
Error Code: <{mid04.ErrorCode}>
Failed MID: <{mid04.FailedMid}>");
}
else
Log.Information($"Manual Mid Response Without error {pack} && Mid {pack.HeaderData.Mid}");
}
else
Log.Information($"Manual Mid Response {pack}-null");
}
private void DriverForm_FormClosing(object sender, FormClosingEventArgs e)
{
Log.Information("Closing App");
}
}
}
amit-tomar-github
xGusu
Rickedb
I was communicating to one Open protocol controller with 3 tool. So first we try to use MID0100 but for that we are getting parsing error while receiving the response from the controller. So vendor of controller suggest that we can use 3 different port for 3 tool of the controller so we changed accordingly. We are testing everthing with the sample app in the repo. So we connected successfully but we are getting the response from all the 3 tool multple times. Even controller is sending one time but we are receiving multiple times. This is the first problem we faced but after some time we are having another big problem , controller is sending the data of all the 3 tool but we are receiving only for either 1 or 2 tool. When we restart the app then we again receive the data from all the 3 tool for 2-3 times but again then we received the data only for 1 or 2 tool. Here I am attaching code and log file as well. Log_20201001.log
Code.txt