Closed csecht closed 5 years ago
The updates look good. Surprised I had so many typos! I am concerned that the description of the fan behavior may be too specific. My experience with the Radeon VII is a bit different from yours. Example is if I save 80% multiple times, it settles at around 92 to 93%. So maybe there should be just a general statement about inaccurate behavior so that users don't expect something specific.
Okay, yes, thanks. I generalized that description and made a new pull request.
On Mar 20, 2019, at 6:12 PM, Rick notifications@github.com wrote:
The updates look good. Surprised I had so many typos! I am concerned that the description of the fan behavior may be too specific. My experience with the Radeon VII is a bit different from yours. Example is if I save 80% multiple times, it settles at around 92 to 93%. So maybe there should be just a general statement about inaccurate behavior so that users don't expect something specific.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Ricks-Lab/amdgpu-utils/pull/14#issuecomment-475063936, or mute the thread https://github.com/notifications/unsubscribe-auth/AtlRQj_-pcNdtW6OaSZnLX_2m6r2Eeicks5vYsBUgaJpZM4cAIMy.
A few edits for you to consider. I added a couple paragraphs in the -pac section.