Ricks-Lab / gpu-utils

A set of utilities for monitoring and customizing GPU performance
GNU General Public License v3.0
142 stars 23 forks source link

amdgpu-ls driver check and warning needs editing #30

Closed csecht closed 5 years ago

csecht commented 5 years ago

From the recent Master, from amdgpu-ls I get the warning:

Command '['dpkg', '-l', 'amdgpu-pro']' returned non-zero exit status 1.
Warning: amdgpu drivers not may not be installed.

True, I don't have amdgpu-pro installed, but amdgpu is:

~/Desktop/amdgpu-utils$ dpkg -l amdgpu
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name              Version            Architecture       Description
+++-=================-==================-==================-=========================================
ii  amdgpu            19.30-838629       amd64              Meta package to install amdgpu components.

Shouldn't the driver check also include the amdgpu All-Open stack as well as the Pro stack?

Ricks-Lab commented 5 years ago

For some reason, 19.20 didn't show anything for amdgpu, so I made some changes to check for amdgpu-core, amdgpu, and amdgpu-pro. Looks like amdgpu is back for 19.30, but I need to improve the robustness of the latest approach.

Ricks-Lab commented 5 years ago

I have made some changes that should be more robust. I checked on 19.30 download, but it says that it is fop 5700 only, so I did not install it. Let me know of any issues.

csecht commented 5 years ago

I was thinking of getting a 5700, but haven’t yet. I never installed 19.1, but have found no problems running 19.30 with my current RX460, 560, 570s.

On Jul 11, 2019, at 5:36 AM, Rick notifications@github.com wrote:

I have made some changes that should be more robust. I checked on 19.30 download, but it says that it is fop 5700 only, so I did not install it. Let me know of any issues.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Ricks-Lab/amdgpu-utils/issues/30?email_source=notifications&email_token=ALMVCQQ5BNQ4SOGGDEG2KTDP64ELBA5CNFSM4H7GLPIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZWJDJY#issuecomment-510431655, or mute the thread https://github.com/notifications/unsubscribe-auth/ALMVCQR24REOCOWNLFJHCQLP64ELBANCNFSM4H7GLPIA.

csecht commented 5 years ago

And yes, with the new master I no longer get then "no driver" warning, just the usual all-okay:

AMD Wattman features enabled: 0xffff7fff
amdgpu version: 19.30-838629
2 AMD GPUs detected, 2 may be compatible, checking...
2 are confirmed compatible.
Ricks-Lab commented 5 years ago

Thanks for confirming.