search

Ricks-Lab / gpu-utils

A set of utilities for monitoring and customizing GPU performance
GNU General Public License v3.0
136 stars 23 forks source link

Reduce minimal required version for python-six #65

Closed smoe closed 4 years ago

smoe commented 4 years ago

Hi Rick, With the the new release of Ubuntu ante portas I have just updated the Debian package of your amdgpu-utils. In an attempt to repeat the effort on Ubuntu 18.04 I found that the Python3-six package was only available at an earlier version. Adjusting for that the package worked. Please consider to adjust the minimal versions of your dependencies, and maybe express them as minimal not as an explicit demand for a particular version? Cheers, Steffen

Ricks-Lab commented 4 years ago

Hi Rick, With the the new release of Ubuntu ante portas I have just updated the Debian package of your amdgpu-utils. In an attempt to repeat the effort on Ubuntu 18.04 I found that the Python3-six package was only available at an earlier version. Adjusting for that the package worked. Please consider to adjust the minimal versions of your dependencies, and maybe express them as minimal not as an explicit demand for a particular version? Cheers, Steffen

Hi Steffan, I am concerned that a major revision change could break the tools, as I have seen in the past. Is it appropriate to use a statement like this: matplotlib>=3.1,<4.0

Rick

smoe commented 4 years ago

I would need to investigate that myself now. There was no problem with matplotlib, so maybe you just leave it for now. Many thanks! Steffen

Ricks-Lab commented 4 years ago

I have made the change only yo the venv requirements file which is not part of the release and it seem to be ok. I have finalized changes and up-ed the revision to v3.0.1. Let me know if anything else needs to be done to support the release.

Regards, Rick