RickyCielma / opendlp

Automatically exported from code.google.com/p/opendlp
0 stars 0 forks source link

Win Agent scan: OpenDLP directory not removed when using 'uninstall' command #85

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Start a Windows filesystem (agent) scan
2. Go to "View Scans/Results" -> select scan -> "View Scan Details"
3. Click "Uninstall" for a specific system

What is the expected output? What do you see instead?
I expect the C:\Program Files\OpenDLP directory (or w/e is specified) to be 
deleted from the system being scanned.  However, this directory remains present 
when uninstalling the scan via the above method.

What version of the product are you using? On what operating system?
0.5.1 - VM.

Additional info:
I believe I have identified a fix.  Line 968 in control.html has an extra 
double quote (escaped) after /S.  Current line:
my $command = "winexe --user=\'$profile_info{domain}\'\\$escape_user 
--password=$escape_pass //$ip \'cmd.exe /c rd \"$profile_info{path}\" /Q 
/S\"\'";

Fixed line:
my $command = "winexe --user=\'$profile_info{domain}\'\\$escape_user 
--password=$escape_pass //$ip \'cmd.exe /c rd \"$profile_info{path}\" /Q /S\'";

I've tested this fix and it appears to work.

Note: Uninstalling all agents in a scan from the "View Scan/Results" page does 
not produce this issue.  I believe this is because using that link executes 
line 854 instead (which is what I based my fix off of).

Original issue reported on code.google.com by burnfrom...@gmail.com on 31 Dec 2012 at 8:35

GoogleCodeExporter commented 9 years ago
Thanks for looking into this and for the fix. I'll roll this into my next 
release.

Original comment by andrew.O...@gmail.com on 27 Jan 2013 at 9:11

GoogleCodeExporter commented 9 years ago
I've put this fix into control.html and have attached the fixed version of the 
file.

Instructions to install:

1. Go to the /var/www/OpenDLP/web/bin/ directory on your OpenDLP host.
2. Make a backup copy of the current control.html file
3. Upload the control.html file attached to this post
4. chmod +x control.html (to mark it executable)

Original comment by nroe...@paysw.com on 19 Apr 2013 at 5:15

Attachments: