RicoSuter / NJsonSchema

JSON Schema reader, generator and validator for .NET
http://NJsonSchema.org
MIT License
1.38k stars 532 forks source link

TypeScriptGeneratorSettings.HandleReferences is broken in Axios template #1640

Closed PeterDraex closed 10 months ago

PeterDraex commented 10 months ago

TypeScript code generated with template Axios can not handle references. It does have definition of jsonParse function, which contains the reference-handling code, but this function is not called from anywhere.

Tested on version 14.0.0-preview008.

My code for running generation:

public async Task<string> Generate()
{
    var document = await OpenApiDocument.FromUrlAsync(swaggerSpecUrl);

    var settings = new TypeScriptClientGeneratorSettings
    {
        Template = TypeScriptTemplate.Axios,

    };

    settings.TypeScriptGeneratorSettings.PropertyNameGenerator = new CustomPropertyNameGenerator();
    settings.TypeScriptGeneratorSettings.TypeScriptVersion = 5.2M;
    settings.TypeScriptGeneratorSettings.MarkOptionalProperties = false;
    settings.TypeScriptGeneratorSettings.HandleReferences = true;

    var generator = new TypeScriptClientGenerator(document, settings);
    var code = generator.GenerateFile();

    return code;
}
PeterDraex commented 10 months ago

Moving the issue to the correct repo: #4558