Feature Suggestion: Support Additional Data Annotation Attributes

[nickcox]

Would you consider adding support for the full set of annotation attributes supported by JSON.Net Schema?

From the page:

• [x] RequiredAttribute | Property will be required.
• [x] MinLengthAttribute | minLength of a string or the minItems in an array.
• [x] MaxLengthAttribute | maxLength of a string or the maxItems in an array.
• [x] RegularExpressionAttribute | String pattern.
• [x] RangeAttribute | Number minimum and maximum.
• [x] StringLengthAttribute | String minLength and maxLength. https://github.com/NJsonSchema/NJsonSchema/commit/fe0b60ae23c7fc1f242eb7d2a4fac889b85b1ffb
• [ ] EnumDataTypeAttribute | Enum type used to generate enum values.
• [x] DataTypeAttribute | String format depending on the DataType value. Supports Url, Date, Time, DateTime, EmailAddress, PhoneNumber (sets the JSON Schema "format").
• [ ] UrlAttribute | String uri format (sets the JSON Schema "format").
• [ ] PhoneAttribute | String phone format (sets the JSON Schema "format").
• [ ] EmailAddressAttribute | String email format (sets the JSON Schema "format").

Definition of Done:

• Implemented attribute handling
• Added unit test
• Updated wiki

[RicoSuter]

Thanks for listing all of available attributes. We should implement these in the JSON Schema generator...

[nickcox]

Awesome. I'm happy to have a crack at this if it's not too difficult.

[RicoSuter]

Yes, I think most attributes should be easy to implement...

[RicoSuter]

Implemented StringLengthAttribute in commit https://github.com/NJsonSchema/NJsonSchema/commit/fe0b60ae23c7fc1f242eb7d2a4fac889b85b1ffb

[RicoSuter]

With https://github.com/NJsonSchema/NJsonSchema/issues/189 phone and email should be handled too.. we should add unit tests for them

[psandgren]

Hey! Is this supposed to be implemented? I see the tests, but codegeneration from NSwag doesn't really add the EmailAddressAttribute. Where to look? What to fix? How can I help? :)

[RicoSuter]

I think the idea is to add this support in the DTO to JSON Schema side, not the code generator...

[danielniccoli]

Is there a chance to also include CustomValidation support?