Angular typescript client generation support for DeepObject

RicoSuter / NSwag

The Swagger/OpenAPI toolchain for .NET, ASP.NET Core and TypeScript.

http://NSwag.org

MIT License

6.69k stars 1.24k forks source link

Angular typescript client generation support for DeepObject #1665

Open fivage opened 5 years ago

fivage commented 5 years ago

I think the section from /src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.QueryParameter.liquid

{% elseif parameter.IsDeepObject -%}

must also be added to the typescript version in /src/NSwag.CodeGeneration.TypeScript/Templates/Client.RequestUrl.liquid for correct DeepObject suppor.

RicoSuter commented 5 years ago

~~@crfloyd can you quickly check this?~~ sorry to bother you, it's TypeScript

Ref: https://github.com/RSuter/NSwag/pull/1342

RicoSuter commented 5 years ago

Deep objects are not yet supported by the TypeScript templates... probably more is needed than just adding this line :-)