search

RicoSuter / NSwag

The Swagger/OpenAPI toolchain for .NET, ASP.NET Core and TypeScript.
http://NSwag.org
MIT License
6.78k stars 1.29k forks source link

Added tests for "id:{id}" patterns. #4634

Closed paulomorgado closed 10 months ago

paulomorgado commented 11 months ago

Addresses concerns in #4620.

Added disabling CS8618 for the declaration of the _baseUrl field as it is set via the BaseUrl property.

#pragma warning disable 8618 // Set by constructor via BaseUrl property
    private string _baseUrl;
#pragma restore disable 8618 // Set by constructor via BaseUrl property
FlorianGrimm commented 10 months ago

I think the 2cd pragma is wrong. Shouldn't it be?

    #pragma warning disable 8618 // Set by constructor via BaseUrl property
        private string _baseUrl;
    #pragma warning restore 8618 // Set by constructor via BaseUrl property
paulomorgado commented 10 months ago

Thanks for the heads up, @FlorianGrimm. It's being solved in #4659

FlorianGrimm commented 10 months ago

@paulomorgado hope it didn't hurt too much. txs for your work