Keep v14 OpenApiDocumentGeneratorSettings retro-compatibility with v13

[paulomorgado]

This breaking change introduced in v14 is a binary breaking change that forces all components using this to be upgraded.

I see 2 issues here:

• The API moved to the SchemaSettings property (of type JsonSchemaGeneratorSettings).
• OpenApiDocumentGeneratorSettings no longer extends JsonSchemaGeneratorSettings.

A nice to have obsolescence plan would be to:

• v14
  • Keep OpenApiDocumentGeneratorSettings extending JsonSchemaGeneratorSettings.
  • Proxy those APIs to the SchemaSettings property on OpenApiDocumentGeneratorSettings.
  • Apply the ObsoleteAttribute with IsError set to false to the obsolete APIs.
  • This will allow code to be compiled and run against the old API.
• v15
  • Change IsError on the ObsoleteAttribute to true.
  • This will allow code to run, but not compiled against the old API.
• v16
  • Remove the JsonSchemaGeneratorSettings base class.

Note: I haven't evaluated the feasibility of keeping the JsonSchemaGeneratorSettings base class.

[RicoSuter]

This doesnt work because now there is not only one JsonSchemaGeneratorSettings but two:

The NewtonsoftJsonJsonSchemaGeneratorSettings and SystemTextJsonJsonSchemaGeneratorSettings which both inherit from JsonSchemaGeneratorSettings... this is why there is this breaking change anyway, and also why this is part of the major version change...

there are quite a few other breaking changes also in NJS that in the end backward compat will not be available anyway.

[paulomorgado]

I saw that.

The main issue here is that JsonSchemaGeneratorSettings's members are not virtual and there's no way proxying them.

Since this is not possible, it's, probably, too much effort to keep source compatibility when binary compatibility is not possible.

On the other hand, it would guide the user on how to change the source code.