search

RicoSuter / NSwag

The Swagger/OpenAPI toolchain for .NET, ASP.NET Core and TypeScript.
http://NSwag.org
MIT License
6.69k stars 1.23k forks source link

build: fix .net8 target while publishing artifacts #4680

Closed krzyhan closed 8 months ago

krzyhan commented 8 months ago

Seems like there is a bug (typo) and therefore the artifacts are copied into a different place

krzyhan commented 8 months ago

@lahma I also noticed that NSwag.Commands is missing net8.0 target.

Should I added in this PR?

lahma commented 8 months ago

@lahma I also noticed that NSwag.Commands is missing net8.0 target.

Should I added in this PR?

Hmmm.. probably wouldn't hurt as the csproj has conditional references that aren't even being triggered due to missing net8.0 target framework.

dylanvdmerwe commented 8 months ago

Can we get this released please?

MehdiElMellali commented 8 months ago

How can I obtain this fix? Is it through a new update of the Negut package?

Saibamen commented 8 months ago

@MehdiElMellali: Please update to v14.0.1

dylanvdmerwe commented 8 months ago

https://github.com/RicoSuter/NSwag/issues/4699

14.0.1 is not available on npm.

dennisdevetter commented 8 months ago

Any ETA when fix 14.0.1 will be available for the .NET8 runtime ?

oliverw commented 8 months ago

@MehdiElMellali: Please update to v14.0.1

Are we supposed to compile NSwagStudio from source? There are no installers for 14.0.1.

Insire commented 8 months ago

as dennisdevetter mentioned, in #4699 , the (release/build) pipeline failed. Publishing installers and packages is/was part of that pipeline. Until that passes, there wont be any packages or installers