Fix missing assignment of base URL

RicoSuter / NSwag

The Swagger/OpenAPI toolchain for .NET, ASP.NET Core and TypeScript.

http://NSwag.org

MIT License

6.69k stars 1.24k forks source link

Fix missing assignment of base URL #4691

Closed paulomorgado closed 8 months ago

paulomorgado commented 8 months ago

Fixes #4637

RicoSuter commented 8 months ago

Is this ready to be merged? Will this fix https://github.com/RicoSuter/NSwag/issues/4697 as well?

paulomorgado commented 8 months ago

Is this ready to be merged? Will this fix #4697 as well?

It validates and "corrects" the base URL, if passed as an argument. So, I hope so.

olegd-superoffice commented 8 months ago

This breaks code generation with /GenerateBaseUrlProperty:false option in v14.0.1 Here's small project which demonstrates regression: GenerateBaseUrlPropertyFalse.zip It works with NSwag.ApiDescription.Client 13.20.0 and 14.0.0 but fails with 14.0.1

paulomorgado commented 8 months ago

@olegd-superoffice, please open an issue tagging me and provide the swagger used.

soligen2010 commented 7 months ago

I think this PR broke BaseUrl. Please see issue #4764