search

RicoSuter / NuGetReferenceSwitcher

Visual Studio extension to switch between NuGet and project references.
http://nugetreferenceswitcher.org
Microsoft Public License
208 stars 69 forks source link

Kwality koder/fix issues 32 and 33 #34

Closed KwalityKoder closed 6 years ago

KwalityKoder commented 6 years ago

Fix issues 32 and 33

KwalityKoder commented 6 years ago

Fix issues 32 and 33

RicoSuter commented 6 years ago

Thanks for the pr. Is this ready?

KwalityKoder commented 6 years ago

Thanks for creating NuGetReferenceSwitcher in the first place - excellent work.

Yes the PR is ready - just pull from master on my fork.

From: Rico Suter [mailto:notifications@github.com] Sent: 05 October 2017 17:46 To: RSuter/NuGetReferenceSwitcher NuGetReferenceSwitcher@noreply.github.com Cc: KwalityKoder mark.hemingway@btinternet.com; State change state_change@noreply.github.com Subject: Re: [RSuter/NuGetReferenceSwitcher] Kwality koder/fix issues 32 and 33 (#34)

Thanks for the pr. Is this ready?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/RSuter/NuGetReferenceSwitcher/pull/34#issuecomment-334524112 , or mute the thread https://github.com/notifications/unsubscribe-auth/Ae8AaBsvJRBxwPWL3bNYEZ1kvQtGHX5Gks5spQfdgaJpZM4PvV3P . https://github.com/notifications/beacon/Ae8AaDEsutxeqOuM2R7UlQD02ZYeQN66ks5spQfdgaJpZM4PvV3P.gif

RicoSuter commented 6 years ago

Where is FixUpNuGetReferences used?

KwalityKoder commented 6 years ago

Forget the branch - just pull from master. I removed that unused code there.

It was my original (failed ) attempt at getting rid of the SpecificVersion flag.

From: Rico Suter [mailto:notifications@github.com] Sent: 05 October 2017 19:33 To: RSuter/NuGetReferenceSwitcher NuGetReferenceSwitcher@noreply.github.com Cc: KwalityKoder mark.hemingway@btinternet.com; State change state_change@noreply.github.com Subject: Re: [RSuter/NuGetReferenceSwitcher] Kwality koder/fix issues 32 and 33 (#34)

Where is FixUpNuGetReferences used?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/RSuter/NuGetReferenceSwitcher/pull/34#issuecomment-334553044 , or mute the thread https://github.com/notifications/unsubscribe-auth/Ae8AaPL4Vlwxseum-iv7-7185SP6mjgfks5spSDBgaJpZM4PvV3P . https://github.com/notifications/beacon/Ae8AaDBSCdMHtA_ReRK8AdnYMTmKcx5Bks5spSDBgaJpZM4PvV3P.gif

KwalityKoder commented 6 years ago

Any idea when the PR will be completed and a new release of NuGetReferenceSwitcher created? As you've noticed you'll need to delete the unused FixUpNuGetReferences() method. Other than that, this branch is basically the same as the last commit on master on my forked repo.

RicoSuter commented 6 years ago

NuGetReferenceSwitcher.zip

Can you test the extension? If it works, ill release it on the gallery..

KwalityKoder commented 6 years ago

OK will do.

KwalityKoder commented 6 years ago

It works in the sense that it fixes the two issues I raised.

From: Rico Suter [mailto:notifications@github.com] Sent: 06 October 2017 12:48 To: RSuter/NuGetReferenceSwitcher NuGetReferenceSwitcher@noreply.github.com Cc: Mark Hemingway mark.hemingway@btinternet.com; State change state_change@noreply.github.com Subject: Re: [RSuter/NuGetReferenceSwitcher] Kwality koder/fix issues 32 and 33 (#34)

NuGetReferenceSwitcher.zip https://github.com/RSuter/NuGetReferenceSwitcher/files/1362556/NuGetReferenceSwitcher.zip

Can you test the extension? If it works, ill release it on the gallery..

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/RSuter/NuGetReferenceSwitcher/pull/34#issuecomment-334732837 , or mute the thread https://github.com/notifications/unsubscribe-auth/Ae8AaPWCH0IBU1kFPnDVwK00NYgS2Ovtks5sphNYgaJpZM4PvV3P . https://github.com/notifications/beacon/Ae8AaGcLn_bu9bB8ruj34gp8ZEpG2HpKks5sphNYgaJpZM4PvV3P.gif