Added a filter for overridden hub lifetime methods

RicoSuter / SigSpec

Specification and code generator for SignalR Core.

MIT License

159 stars 37 forks source link

Added a filter for overridden hub lifetime methods #12

Closed austinsc closed 5 years ago

austinsc commented 5 years ago

This PR prevents the operation methods from producing operations like 'OnConnectedAsync' and other methods declared in Hub and Hub<>.

RicoSuter commented 5 years ago

Thanks for the PR, but please move the js commit into a second PR

austinsc commented 5 years ago

Oops, meant to separate that.

On Mar 9, 2019, at 1:43 PM, Rico Suter notifications@github.com wrote:

Thanks for the PR, but please move the js commit into a second PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RSuter/SigSpec/pull/12#issuecomment-471210593, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTxCUHw2RKq4m3WM_Xdj_MD2PVkpx57ks5vVADQgaJpZM4bmln-.

austinsc commented 5 years ago

I'll recreate against the appropriate branch

RicoSuter commented 5 years ago

For the other pr you should use the conversion methods from here: https://github.com/RSuter/NJsonSchema/blob/master/src/NJsonSchema/ConversionUtilities.cs