search

RicoSuter / SigSpec

Specification and code generator for SignalR Core.
MIT License
159 stars 37 forks source link

#8 Fixed duplicate import directive #9

Closed Alamaster99 closed 5 years ago

Alamaster99 commented 5 years ago

I have separated the import directive into another liquid template.

Closes https://github.com/RSuter/SigSpec/issues/8

RicoSuter commented 5 years ago

Updated PR with NJS alignment.

RicoSuter commented 5 years ago

Thanks for the PR!

RicoSuter commented 5 years ago

How are you using this project ATM?

Alamaster99 commented 5 years ago

Hi! Thanks for the quick fix!

We are developing microservices with asp.net core and my team is responsible for backend services. We are using openapi and Swagger to generate C# controllers and TypeScript clients for the API between frontend and backend. Now we are implementing server push functionality using SignalR. So we wanted to do something similar.

We have a project with abstract hub classes and we generate nuget package from it and also using SigSpec we generate the TypeScript to be used by Frontend team.

RicoSuter commented 5 years ago

And you are using the sigspec code as copy in your solution? You know that this is an experimental project?

Alamaster99 commented 5 years ago

Yeah I know it's experimental. I have made a nuget package out of it (for our dedicated nuget server).

Is that a problem? I know, that you cannot guarantee anything, but I don't mind as long as the source code is available. It's not a crucial functionality, we can always write the TypeScript manually, but I like this tool.

Are you OK with it?

RicoSuter commented 5 years ago

Of course this is fine, but please dont publish an “inofficial” public nuget package :-)

Alamaster99 commented 5 years ago

No I am not planning on publishing anything, It is really our private company nuget server.

Thanks again for all your work!