search

RicoSuter / VisualJsonEditor

A JSON schema based file editor for Windows.
http://visualjsoneditor.org
MIT License
349 stars 87 forks source link

Handle contentEncoding base64 #33

Closed Indigo744 closed 5 years ago

Indigo744 commented 5 years ago

Implements #29

Handle contentEncoding (base64 only) property as defined in: https://json-schema.org/understanding-json-schema/reference/non_json_data.html

Indigo744 commented 5 years ago

I am not really sure why AppVeyor failed to compile.

It compiles correctly in DEBUG or RELEASE on my machine.

Maybe an issue with the version? I am using Visual Studio Enterprise 2019 (16.2.3).

RicoSuter commented 5 years ago

Is the PR ready to be merged? CI build is also fixed.

Indigo744 commented 5 years ago

Ah good, I wondered why it fails since it works on my machine.

I think it should be good (but I'm never against a review 😉)

RicoSuter commented 5 years ago

Code looks good to me. Yeah it was using an old vs/compiler version where ?. was not supported.

Indigo744 commented 5 years ago

Thank you!