Ricochet-Exchange / ricochet-frontend

Enter the world of real-time investing
https://www.ricochet.exchange/
Other
46 stars 78 forks source link

Add prettier and lint all the code #324

Closed bigint closed 2 years ago

bigint commented 2 years ago

I'll be happy to work on this, this will be a bit huge effort 🤗

josealonso commented 2 years ago

@bigint, I put this label because we already have prettier and linter for the Solidity code. I agree with you, but this decision has to be taken by a frontend team leader. I guess many of us use VSCode or an equivalent tool, where the linter plugin is already installed. Anyway, this has to be integrated by the CI tool and I think it is already done.

bigint commented 2 years ago

@josealonso I can see only linter is only available in CI, the prettier is not there and our codebase is not properly prettified.

Yes some has prettier installed in vscode but the prettier configuration should be added to make the prettier works same for all

josealonso commented 2 years ago

@bigint, I agree, but you might want to comment this on discord with other developers. We still don't have prettier configured on the main branch of the backend. It takes time. And make sure @samirsalem integrates that in the CI tool. I just removed the invalid label.

bigint commented 2 years ago

We need wait for @mikeghen, this one need to handled carefully else it will cause conflicts for all open PRs in the repo.

mikeghen commented 2 years ago

Yeah, lets wait until we go live with v2 and merge all things back to main, and tag the release, then lets do this issue

mikeghen commented 2 years ago

@abhisheknaiidu, did you also lint all the code? I don't see that in the commit?

mindsgn commented 2 years ago

I will take this issue.

Seroxdesign commented 2 years ago

@mindsgn

Is there any progress on this?

mindsgn commented 2 years ago

@Seroxdesign yes, I will make a PR tomorrow.

mindsgn commented 2 years ago

@Seroxdesign done: https://github.com/Ricochet-Exchange/ricochet-frontend/pull/750