chore: fix stream issue for larger streams

Ricochet-Exchange / ricochet-frontend

Enter the world of real-time investing

https://www.ricochet.exchange/

Other

46 stars 78 forks source link

chore: fix stream issue for larger streams #871

Closed abhisheknaiidu closed 1 year ago

abhisheknaiidu commented 1 year ago

context: when opening 100,000 RIC per month stream. It did not work, but when changed the number to 100,005 RIC per month it worked.

ref - https://app.dework.xyz/ricochet-exchange-da/main-space-32902?taskId=4177b7b6-5d83-49d7-a8bb-481e91f449d7

solution: Math.floor was not that calculating that precisely so using big.js for all the mathematical calculations, it seems to be working fine now

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
ricochet-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 19, 2023 at 9:17PM (UTC)

github-actions[bot] commented 1 year ago

Seroxdesign commented 1 year ago

x;, vd

Transaction is populating with [object object] and transaction is failing tried to open a stream of 100k RIC > USDC

mikeghen commented 1 year ago

@Seroxdesign I'll leave the squash and merge to you

Seroxdesign commented 1 year ago

@Seroxdesign I'll leave the squash and merge to you @abhisheknaiidu you're passing a wrong value to startFlow

Error: [object Object]
    e ethereum.ts:298
    Babel 5
        d
        _invoke
        x
        r
        s
[startFlow.ts:32:10](https://ricochet-frontend-afozekt2o-seroxdesign.vercel.app/static/js/store/main/sagas/startFlow.ts)

This is not working properly