Ridanisaurus / EmendatusEnigmatica

Minecraft Unification Mod
MIT License
38 stars 16 forks source link

EE Generated Blocks don't render properly in some JEI recipes. #206

Open FooterManDev opened 1 year ago

FooterManDev commented 1 year ago

Issue description

When EE Blocks are involved with recipe types compactcrafting:miniaturization (Compact Crafting) and anything with Lychee They render with incorrect textures. Example: image Texture is supposed to be Green, as shown in the index to the right. Another example: image Colors are correct, but the texture is broken.

Miniaturization screenshot goes dead in 31 days, sorry! Github won't let me upload two images.

Steps to reproduce

Install either mods mentioned, and JEI. Create a Recipe requiring an EE Block. (Datapack or KubeJS) View result in JEI.

Minecraft version

1.19.2 (Latest)

Forge version

43.2.8

Emendatus Enigmatica version

2.1.x (Latest)

Other relevant versions

JEI - 11.6.0.1015 Compact Crafting - 3.1.0 Lychee - 3.11.0

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

Ridanisaurus commented 1 year ago

Do you have textures for these blocks, or are they using the tint system?

FooterManDev commented 1 year ago

Tint system.

Ridanisaurus commented 1 year ago

Could you try with a texture please. I have a suspicion that these 2 mods are not taking cutout blocks into consideration maybe.

FooterManDev commented 1 year ago

I cannot modify the block textures. I assume EE generates assets later than everything else, because adding the resource via resource pack or Kube doesn't modify the texture.

Ridanisaurus commented 1 year ago

Using a Resource Pack or KubeJS to add textures should work. Please see example how Enigmatica team are using KubeJS for textures: https://github.com/EnigmaticaModpacks/Enigmatica9/tree/master/kubejs/assets/emendatusenigmatica/textures/blocks

FooterManDev commented 1 year ago

That unfortunately does not work. The block is still unchanged. image image

Ridanisaurus commented 1 year ago

You need to remove the color from the JSON file

Ridanisaurus commented 1 year ago

Did that fix the issue with the rendering in JEI Recipes?

FooterManDev commented 1 year ago

image Removing color did fix the resource issue. image Additionally, it renders correctly in the JEI recipe.

Ridanisaurus commented 1 year ago

Out of curiosity, could you please test with Mangrove Roots or Oak Leaves as a block, and see if that works. If I recall correctly Mangrove Roots are CUTOUT as well similar to EE Tint Blocks. My suspicion is that the mod devs didn't take CUTOUT blocks as a valid render block in their JEI Recipe, so testing these Vanilla blocks should help confirming that.

FooterManDev commented 1 year ago

I deeply apologize for my absence, I forgot about this thread. image This is a recipe with Oak Leaves and Mangrove Roots (Not re-textured EE blocks, the actual blocks)