search

Ridanisaurus / EmendatusEnigmatica

Minecraft Unification Mod
MIT License
38 stars 16 forks source link

Multiple Biome Tags in Deposit "biomes" Field #210

Open vertexcubed opened 1 year ago

vertexcubed commented 1 year ago

Describe the feature you'd like

when making a deposit, you're only allowed a single biome tag in the biomes field, which is quite annoying. It would be nice if you could put multiple.

Examples:

{
    "type": "emendatusenigmatica:vanilla_deposit",
    "dimension": "minecraft:overworld",
    "registryName": "my_deposit",
    //currently not valid, it would be nice if it was
    "biomes": ["#minecraft:is_ocean", "#minecraft:is_river"],
    "config": {...}
}

{
    //using biome tags and biome ids together would also be very useful
    "biomes": ["#minecraft:is_ocean", "minecraft:dark_forest"] 
}

Describe alternatives you've considered

The only real alternative right now is to make a separate biome tag that contains every tag / biome you want to use, which is not ideal.

Additional context

No response

Ridanisaurus commented 1 year ago

As far as I remember this is something I looked into while working on the refactor and it was not possible due to how 1.19 handles world generation. It is an either/or situation. I'll look into it again for the 1.20 version (because OF COURSE Mojang re did world generation .. again) and will see how it goes.