search

Ride-The-Lightning / RTL-Design

Ride The Lightning - A full function web browser app for LND and C-Lightning.
MIT License
12 stars 4 forks source link

A graph to show the routing fee earned. #31

Open saubyk opened 4 years ago

saubyk commented 4 years ago

Construct a chart to show the routing fee earned on a historical basis.

saubyk commented 4 years ago

Development ticket: https://github.com/Ride-The-Lightning/RTL/issues/202

swedishfrenchpress commented 3 years ago

Hey all, I'm interested in taking a stab at this. Are there are any data vis libraries that are already vetted I can take a look at it? Would the Material Design data viz guide be a good place to state?

ShahanaFarooqui commented 3 years ago

@swedishfrenchpress It is a duplicate of https://github.com/Ride-The-Lightning/RTL-Design/issues/52. The developement for the same is https://github.com/Ride-The-Lightning/RTL/issues/202.

At the time of developlemt we decided to move forward with ngx-charts library. Below are some of the points of consideration:

Priority 1: ngxCharts pros: maintained by swimlane, Using d3 for charts, size ~11 MB cons: 11 dependencies demo: https://swimlane.github.io/ngx-charts/#/ngx-charts/bar-vertical privacy: https://swimlane.com/privacy-policy/

Priority 2: highcharts-angular pros: 1 dependencies, official wrapper of highcharts cons: size ~42 MB, free for non-commercial purpose (might get into trouble in future) demo: https://highcharts.com/demo

BTW, google also has a charts library, known as google charts. But, it can not be used offline, so it will definitely capture user's data. https://developers.google.com/chart/interactive/docs/gallery

Currently, this report can be found under => Lightning => Reports => Routing Fees. Sample report:

image