Ride-The-Lightning / RTL

Ride The Lightning - A full function web browser app for LND, C-Lightning and Eclair
MIT License
731 stars 156 forks source link

Make RTL compatible with Eclair 0.10.0 new audit format #1363

Closed fishcakeday closed 3 months ago

fishcakeday commented 3 months ago

This small change fixes the compatibility with the current release of Eclair (0.10.0) by using the settledAt instead of timestamp for the new version. It is also backwards compatible, so it will work on 0.9.0 and below.

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent update introduces a refined approach to handling timestamps in functions related to fees and payments. By prioritizing the use of settledAt over timestamp, the system ensures more accurate time data for calculations, enhancing precision in fee and payment operations.

Changes

Files Change Summary
.../eclair/fees.js, .../fees.ts - Use settledAt for timestamp if available
- Update conditions for fee calculations based on new timestamp handling
frontend/index.html - Updated main.js script source in index.html from main.4f7f075c33c518c3.js to main.1824016c5cb16488.js
rtl.js - Added process event listener for 'SIGINT' to exit process in rtl.js
src/app/app.component.html, src/app/app.component.ts - Restructured conditional blocks for improved readability and maintenance in app.component.ts and related HTML
src/app/shared/components/node-config/services-settings/boltz-service-settings/boltz-service-settings.component.html - Updated hyperlink in alert message to https://docs.boltz.exchange/v/boltz-client/ in boltz-service-settings.component.html
src/app/shared/directive/clipboard.directive.ts - Updated ClipboardDirective to check navigator.clipboard API availability for text copying
src/app/shared/services/consts-enums-functions.ts - Updated VERSION constant to '0.15.1-beta' and added new enum value'transaction.lockupFailed' = 'Lockup Transaction Failed'inconsts-enums-functions.ts`

🐰✨
In the land of code, where the data bytes roam,
A change was made, in the digital dome.
"Use settledAt, not timestamp," they said,
For accuracy's sake, in the code we thread.
Now fees and payments, with precision we pair,
Thanks to the rabbits, with utmost care. 🌟🐇
🥕🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
ShahanaFarooqui commented 3 months ago

@fishcakeday Thank you for the PR :).