Closed ShahanaFarooqui closed 2 weeks ago
[!WARNING]
Review failed
The pull request is closed.
The recent updates include modifications to ESLint configurations, Dockerfiles, and Angular components. ESLint rules were adjusted to disable certain Angular-specific rules and add new ones. Dockerfiles were updated to refine the npm prune command for better dependency management. Changes in Angular components involved minor code adjustments and reorganization of shared module components.
File Path | Change Summary |
---|---|
.eslintrc.json |
Disabled and added several Angular-specific ESLint rules, modified the parser. |
dockerfiles/Dockerfile , dockerfiles/Dockerfile.arm32v7 , dockerfiles/Dockerfile.arm64v8 |
Updated npm prune command to use --omit=dev and --legacy-peer-deps instead of --production . |
src/app/cln/peers-channels/channels/channels-tables/channel-open-table/channel-open-table.component.ts |
Modified ngOnInit method by removing a line of code. |
src/app/shared/shared.module.ts |
Removed SettingsComponent and AppSettingsComponent , reordered components in the module. |
In the code where changes bloom,
ESLint rules now make room,
Docker prunes with finer grace,
Dependencies in their place.
Angular components realigned,
Shared modules redefined.
Code evolves, a brighter hue,
For every line, a purpose true.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Chores
--omit=dev
and--legacy-peer-deps
options for better dependency management.Refactor
CLNChannelOpenTableComponent
to improve performance.shared.module.ts
and removedSettingsComponent
andAppSettingsComponent
for better module structure.