search

RideNoCo / drt-tds

0 stars 1 forks source link

Make PaymentType optional #69

Closed NomeQ closed 5 months ago

NomeQ commented 5 months ago

Currently the schema has:

    "PaymentTypeList": {
      "type": "array",
      "items": {
        "type": "string",
        "enum": [ "cash", "card", "account", "ticket", "noShow", "providerCompensation" ]
      }
    }

We should make a PaymentTypeListNullable definition so that this value is not required

NomeQ commented 5 months ago

@asiridissa @steverideschedulercom this came up in our testing session this morning. Let me know if you have any objections or thoughts on if this should be implemented different (e.g. with an empty string enum or stringNullable) but it would be good to get this updated asap

ehamilton7 commented 5 months ago

Erica and Harsh agree with Nome (we're on the call) and think this is the best solution.

NomeQ commented 5 months ago

Similarly, 

    "SpecialAttributesList": {
      "type": "array",
      "items": {
        "type": "string",
        "enum": [ "A", "AL", "C", "CU", "D2D", "DA", "DTD", "E", "HI", "IDD", "MI", "NLA", "O", "S", "SA", "SD", "SI", "TD", "U", "VI", "W", "WA", "WAK", "WE", "WT", "WW" ],
        "description": "- A:- Mobility Aid: Ambulatory - AL:- Mobility Aid: Ambulatory lift - C:- Mobility Aid: Cane - CU:- Mobility Aid: Crutches - D2D:- Service Needs: Door to door - DA:- Service Needs: Driver Alert - DTD:- Service Needs: Door THROUGH door - E:- Mobility Aid: Electric wheelchair - HI:- Service Needs: hearing impaired - IDD:- Medical: Intellectually or developmentally disabled - MI:- Medical: Dementia (memory impaired) - NLA:- Service Needs: Never leave alone/ no leave alone - O:- Service Needs: Oxygen - S:- Mobility Aid: Scooter - SA:- Service Needs: Service Animal - SD:- Service Needs: Seizure disorder - SI:- Medical: Speech impaired - TD:- Medical: Temporary Disability - U:- Service Needs: Unstable needs assistance - VI:- Medical: Vision impaired - W:- Mobility Aid: Wheelchair - WA:- Mobility Aid: Walker - WAK:- Mobility Aid: Knee walker - WE:- Mobility Aid: Extended leg w/c = Extended Leg Wheelchair - WT:- Mobility Aid: Transport Chair, Must Transfer - WW:- Mobility Aid: Wide wheelchair"
      }
    },

    "TripPurposeList": {
      "type": "array",
      "items": {
        "type": "string",
        "enum": [ "A", "D", "E", "ED", "G", "HR", "M", "MS", "P", "R", "T" ],
        "description": "- A:- Adult Day Program - D:- Dialysis - E:- Employment - ED:- Educational - G:- Grocery - HR:- Health-Related (includes dentist, pharmacy, etc.) - M:- Medical - MS:- Miscellaneous - P:- Personal - R:- Recreation - T:- Public transit"
      }
    }

These should be nullable as well.

asiridissa commented 5 months ago

Don't we need SpecialAttributesList & TripPurposeList for reporting purposes?

steverideschedulercom commented 5 months ago

We can support those changes but not in time for the testing with Spedsta tomorrow morning.

On Thu, May 2, 2024, 7:40 PM Asiri Dissanayaka @.***> wrote:

Don't we need SpecialAttributesList & TripPurposeList for reporting purposes?

— Reply to this email directly, view it on GitHub https://github.com/RideNoCo/drt-tds/issues/69#issuecomment-2092038400, or unsubscribe https://github.com/notifications/unsubscribe-auth/A745KMIXJ7HXABB2E6UFKBDZAL2IVAVCNFSM6AAAAABHECG34KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSGAZTQNBQGA . You are receiving this because you were mentioned.Message ID: @.***>

ehamilton7 commented 5 months ago

Great - we all agree. @keviniano will you please update the schema (to version 0.15.0) and @asiridissa will you please update the Swagger? @NomeQ please close out this issue. Thank you all!

keviniano commented 5 months ago

I should be able to complete this Monday.

On Fri, May 3, 2024 at 9:54 AM ehamilton7 @.***> wrote:

Great - we all agree. @keviniano https://github.com/keviniano will you please update the schema (to version 0.15.0) and @asiridissa https://github.com/asiridissa will you please update the Swagger? @NomeQ https://github.com/NomeQ please close out this issue. Thank you all!

— Reply to this email directly, view it on GitHub https://github.com/RideNoCo/drt-tds/issues/69#issuecomment-2093394759, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF2E2MQUVLLKBS2L4AX7LZAO6MZAVCNFSM6AAAAABHECG34KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGM4TINZVHE . You are receiving this because you were mentioned.Message ID: @.***>

-- Kevin Chambers (he/him) c: 503.236.7864 @.***