Open vzaluckis opened 3 years ago
Checking the existing value and setting listen-to
only if the new value differs, actually prevents memory corruption from happening.
Oh thanks for this report. This should be an easy fix, let me take it internally and get back to you!
@jsalas98 can you apply you magic here?
@vzaluckis I have made the hotfix for this issue, it is already in master. Thanks for your report, please let us know if this new release fixes your issue.
Hi! I am working on a custom WebRTC service, and there is a stream switching functionality where you switch which input stream gets broadcast to other participants. I have implemented this using the
interpipe*
elements version 1.1.5, making the actual switch by settinginterpipesrc
'slisten-to
property to point to the new stream. All works very well except for the case when the newlisten-to
node is actually the same as it was. In this case, I am seeing a memory corruption, best illustrated by log excerpt (captured withGST_DEBUG
includinginterpipe*:4
).I have not been able to track the issue down myself so far, but I will definitely post a patch if/when I fix it. I am hoping that maybe someone (the authors?) will fix it sooner though.