Riduidel / aadarchi

A maven archetype to generate easily projects allowing architecture description using a mix of C4, agile architecture, Asciidoc and PlantUML
https://riduidel.github.io/aadarchi/
Apache License 2.0
40 stars 12 forks source link

The variable `aadarchi-version` is not used in `pom.xml` #316

Closed lhauspie closed 1 year ago

lhauspie commented 1 year ago

After generating the project with the archectype, the pom.xml define a property aadarchi-version that is not used in the rest of the file. It can be confusing because if I upgrade the version in properties, I expect to update all dependencies version at once what it will not be the case here.

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
...
    <properties>
...
        <!-- Defining a version that doesn't suck -->
        <aadarchi-version>0.1.6</aadarchi-version>
...
    </properties>

    <dependencies>
...
        <dependency>
            <groupId>io.github.Riduidel.aadarchi</groupId>
            <artifactId>base</artifactId>
            <version>0.1.6</version>
        </dependency>
        <dependency>
            <groupId>io.github.Riduidel.aadarchi</groupId>
            <artifactId>github-scm-handler</artifactId>
            <version>0.1.6</version>
        </dependency>
        <dependency>
            <groupId>io.github.Riduidel.aadarchi</groupId>
            <artifactId>adr-tickets-extractor</artifactId>
            <version>0.1.6</version>
        </dependency>
        <dependency>
            <groupId>io.github.Riduidel.aadarchi</groupId>
            <artifactId>maven-metadata-inferer</artifactId>
            <version>0.1.6</version>
        </dependency>
...
    <dependencies>
...
</project>
Riduidel commented 1 year ago

Fixed by #313