Riduidel / aadarchi

A maven archetype to generate easily projects allowing architecture description using a mix of C4, agile architecture, Asciidoc and PlantUML
https://riduidel.github.io/aadarchi/
Apache License 2.0
39 stars 12 forks source link

In Maven TechnologyDetector, filtering should be done before aggregating #399

Closed Riduidel closed 8 months ago

Riduidel commented 8 months ago

Since #394 , we aggregate each groupId to its most popular dependency and then we filter by tags. Unfortunatly, most of the time, the testing tag corresponds with the most used artifacts. As an example, compare ranking/usages of io.quarkus:quarkus-junit5 (ranking: 283, users: 1660), to io.quarkus:quarkus-resteasy (ranking: 436, users: 1064). Since we compare by ranking (users not being always available), junit5 will be priorized, then filtered. So filter out first then rank to avoid that.

Riduidel commented 8 months ago

Fixed in b3f709146c556f0c392d702ac99c15f1850813dc