Riduidel / aadarchi

A maven archetype to generate easily projects allowing architecture description using a mix of C4, agile architecture, Asciidoc and PlantUML
https://riduidel.github.io/aadarchi/
Apache License 2.0
39 stars 12 forks source link

Using DefaultFileSystemConfigBuilder to set authentication in gitlab-scm-handler doesn't work #432

Closed Riduidel closed 1 month ago

Riduidel commented 1 month ago

Even with authentication configured this way, I cannot access Gitlab repository to get the data I want.

My current understanding is that DefaultFileSystemConfigBuilder set options in the FileSystemOptions given as parameter, not in the one given to initialize the gitlab file system (see in GitlabFileSystemProvider). I'm quite sure the same issue also happens in the github-scm-handler.

Riduidel commented 1 month ago

ok, I have a reproducer.

Invoking fileSystemManager#resolveFile(...) will use the FileSystemOptions used to initialize the LocalFileSystem, which doesn't contains the credentials used for gitlab init. As a consequence, it is not possible to access Gitlab credentials and everything fails. The same happens for GitHub, which is kinda cool (because it's currently my main case).