search

Ridwanullahi-code / royal-meals-website

Microverse Module 02 Group Capstone Project: This is educational project is food website that give user a room of different interaction like likes, comment , and read on available foods. Built with HTML, CSS, JavaScript.
MIT License
1 stars 0 forks source link

Kanban Board Setup #1

Open Ridwanullahi-code opened 2 years ago

Ridwanullahi-code commented 2 years ago

https://github.com/Ridwanullahi-code/royal-meals-website/projects/1

We are just only two students

Nemwel-Boniface commented 2 years ago

Hello @Ridwanullahi-code and @kennankole :wave: ,

I'm Nemwel your reviewer for this PR :man_beard:

Good job working on your project so far! :clap: There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Great job setting up the correct linters ✔️ Professional documentation ✔️ Correct workflow ✔️ Meaningful commit messages ✔️

♻️ Required Changes ♻️

This is what I am seeing from your kanban board:

image

This is the desired kanban cards according to the provided template:

Screencast from 24-10-2022 12:13:53 ALASIRI.webm

Check the comments under the review.

[Optional] suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! :partying_face: 👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Nemwel-Boniface in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

alexander16108 commented 2 years ago

Hi TEam 👋🏾 ,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't been addressed yet.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Qoosim commented 2 years ago

Status: Approved :tada: :heavy_check_mark:

Hi @team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Kindly check an optional comment I left under the review :pray:

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.