Closed Rifat8080 closed 1 year ago
Great work so far, You have come a long way, keep moving forwardπ π
You've done well implementing the project requirements, but there are still some issues I think you need to improve on. π π
Well-detailed summaryβ
Kanbarn board setup correctlyπ
β
[ ] You have done great setting up the kanban board. :+1: There is a step you need to complete before moving to the next milestone.
Each of the team members should assign themselves to the correct cards. Decide who will be the assignee for the cards marked as group tasks. All cards on your Kanban board should have assignees.
[ ] According to the project requirement, each card should be assigned to the correct student, Currently, your cards don't have assignees, you should see the profile image of the assignees if done correctly. I'll suggest you update this. :smile:
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi Team,
Great work on making the changes π You've done well implementing the requested changes
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Good luck! π
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
We followed these steps below :
Joined a Zoom call with my team helped each other.
Created an empty repository for the group project.
Followed the steps described in curriculum-tools-copy-projects.
Opened the GitHub project (Kanban board) in the team repo.
Make sure that in the card titles : Student A, Student B, or Student C.
Make sure that each card starts with [Xpt] - that number indicates the number of points that shows how complex the task is. 1 point = 1 hour of work.
According to team members removed all cards with Student C in the title.
Decided who in your team is the Student A, Student B, or Student C.
Assigned cards to the correct members
Here is the link of my GH project link of Kanban Board:
Thanks for your reviewing the regarding matter!π―