search

Rigellute / rigel

🌌 Colorscheme for vim, terminal, vscode and slack - based on the star Rigel ✨.
https://rigel.netlify.com/
512 stars 37 forks source link

:set colorcolumn[...] results in illegible text #2

Closed zatchheems closed 4 years ago

zatchheems commented 4 years ago

Text is illegible when colorcolumn is set. This is easily remedied by setting guifg and guibg to NONE and replacing guibg and ctermbg with dark blues like so:

hi ColorColumn guifg=NONE ctermfg=NONE guibg=#002230 ctermbg=230 gui=NONE cterm=NONE

Screenshots:

With :set colorcolumn=100

rigel-colorcolumn-bug

With :set colorcolumn=100 and highlight edits

rigel-colorcolumn-fixed

The dark blue for the colorcolumn might be a bit too subtle, but the basic idea is there. Could possibly make it the same color as the cursorline (guibg=#001a25 ctermbg=234), like so:

image

zatchheems commented 4 years ago

Not really relevant, but I want to say that I really, really like this color scheme. It's easy on the eyes and one of the few vim color schemes that actually renders JSX nicely.

Rigellute commented 4 years ago

Thanks for this - one major motivation for creating this theme was for better support for JSX and Typescript/Flow types.

And you're right, I had assigned the wrong colours for these properties.

I've fixed in https://github.com/Rigellute/rigel/commit/4d96cbb1af73a8d1d0a562c0f71ec7cfe391b09b

Let me know if this works for you!

image
zatchheems commented 4 years ago

Works like a charm. Looks great!

Rigellute commented 4 years ago

Great to hear!