search

RightCapitalHQ / frontend-style-guide

RightCapital's frontend style guide.
MIT License
7 stars 0 forks source link

feat: remove unnecessary and deprecated rules #166

Closed frantic1048 closed 2 months ago

frantic1048 commented 2 months ago

This PR resolves the step 2 of https://github.com/RightCapitalHQ/frontend-style-guide/issues/159

This PR depends on https://github.com/RightCapitalHQ/frontend-style-guide/pull/160

  1. Reduced redundant rule overrides.
  2. Removed useless rule configs.
  3. Style related rules.
    1. Removed rules that conflict with Prettier (This make us no longer need to ship eslint-config-prettier as a dependency).
    2. Added test to check conflicts with Prettier.
    3. Migrated deprecated style rules to @stylistic/js counterparts.
  4. Legacy rules (prior ESLint v8 )
    1. Removed/Migrated deprecated rules, except these ones(currently the have no ideal replacement, we may fix these rules later):
      • no-buffer-constructor
      • no-return-await
    2. Added test to check deprecated rules.

For detailed rule changes, please see https://github.com/RightCapitalHQ/frontend-style-guide/pull/166/files#diff-6a7b668335f2224bcd651ef1b8dd12c5e8ac3915e02590617e73529a6b5237ce