The purpose of this PR was to make it so that when a user updates their profile in the settings, it broadcasts the changes to the network.
While doing this I attacked the settings page UI, which was a bit tangled/complex from the ConstraintLayout/UI builder. As part of that I changed the app's theme to Material.Light from Holo.Light to fix RMN-36, which came with some changes as well. I then went slightly down a rabbit hole of cleaning up the UI, but mostly constrained that to UsernameOnboardingActivity and the settings page. Now all the strings are in strings.xml and I've started moving margins to dimens.xml for RMN-42.
Meanwhile, I discovered a bug where we'd have a race condition where after
rebinding during aonPause/onStop/onStart/onResume cycle the activity's callback might nto be registered. This manifested as the loading screen just sitting there spinning, until you reloaded the page and updateUI was called again.
The purpose of this PR was to make it so that when a user updates their profile in the settings, it broadcasts the changes to the network.
While doing this I attacked the settings page UI, which was a bit tangled/complex from the
ConstraintLayout/UI builder. As part of that I changed the app's theme to Material.Light from Holo.Light to fix RMN-36, which came with some changes as well. I then went slightly down a rabbit hole of cleaning up the UI, but mostly constrained that toUsernameOnboardingActivityand the settings page. Now all the strings are instrings.xmland I've started moving margins todimens.xmlfor RMN-42.Meanwhile, I discovered a bug where we'd have a race condition where after rebinding during a
onPause/onStop/onStart/onResumecycle the activity's callback might nto be registered. This manifested as the loading screen just sitting there spinning, until you reloaded the page andupdateUIwas called again.