search

Rightpoint / Anchorage

A collection of operators and utilities that simplify iOS layout code.
MIT License
632 stars 46 forks source link

Improve test coverage #39

Open jvisenti opened 7 years ago

jvisenti commented 7 years ago
screen shot 2017-05-05 at 11 16 06 am

Coverage as of 5/5/17

jvisenti commented 7 years ago

Addressed in #42

mpiechocki commented 5 years ago

Is there anything happening with this? I can see #42 is a really good PR but it's not merged. I don't know if I should open another PR with improved test coverage or just wait for #42 to be updated and merged.

ZevEisenberg commented 5 years ago

42 is quasi-abandonware. It was created right as we were switching to Swift 4, and it never made the cut. If you're up for doing the work to port that PR, we'd greatly appreciate it! Feel free to branch from that branch, or start fresh. Thanks for the offer!

ZevEisenberg commented 5 years ago

Oh, and we have newer best practices for code coverage reporting at Raizlabs, mostly ushered in by @chrisballinger's work on the Raizlabs iOS template project and BonMot. Might want to look there for inspiration, because the codecov integration we did in #42 predates that later work.