Refactors shared instances to shared factory to allow parallel testing

Rightpoint / Anchorage

A collection of operators and utilities that simplify iOS layout code.

MIT License

627 stars 46 forks source link

Refactors shared instances to shared factory to allow parallel testing #70

Closed BrianSemiglia closed 3 years ago

chrisballinger commented 3 years ago

@BrianSemiglia Is there a way to salvage this PR? It looks like it was probably mergeable but fell through the cracks.

ZevEisenberg commented 3 years ago

I believe the tests here run pretty quickly. Is it worth trying to make them faster?

BrianSemiglia commented 3 years ago

This was due to an error in my misunderstanding of XCTestCase. I thought each test case was run on a single instance of XCTestCase due to each function being an instance type and then sharing access to view1, view2 and window. I don't think there was a win here.