search

Rightpoint / BonMot

Beautiful, easy attributed strings in Swift
MIT License
3.54k stars 196 forks source link

Readme updates #340

Closed ZevEisenberg closed 3 years ago

ZevEisenberg commented 6 years ago

Fixes #339, plus one other minor fix for something that's been bothering me. @thisisjeffwong I'd appreciate a review of this, if you have time.

ZevEisenberg commented 6 years ago

Code I used to generated this, in case its useful to someone, including me from the future: Dynamic Type Research.zip

raizlabs-oss-bot commented 6 years ago
2 Messages
:book: Test Results
:book: Code Coverage

Current coverage for BonMot.framework is 82.66%

✅ No files affecting coverage found

Powered by xcov

Generated by :no_entry_sign: Danger

thisisjeffwong commented 6 years ago

The graph shows most of the styles not growing in the larger accessibility sizes. However, I noticed that they still do when looking at the Apple typography docs.

I'm not sure which is correct though it doesn't make sense to me why they would have some sizes simply not grow.

I didn't notice the discrepancy before when I filed the ticket.

ZevEisenberg commented 6 years ago

I only updated the two new sizes. I guess I should update all the sizes, just in case they’ve changed. I really should throw together a script that can do this all via a graphing library or something.

cjamie commented 5 years ago

can we also include changing the struct Constants in this PR to enum Constants since its more appropriate as a namespace

ZevEisenberg commented 5 years ago

@cjamie which constants are those? I don’t think it’s related to this PR; would you mind opening a new PR or issue with more detail?

cjamie commented 5 years ago

@ZevEisenberg the ones in the readme