search

Rightpoint / BonMot

Beautiful, easy attributed strings in Swift
MIT License
3.54k stars 196 forks source link

Fix issue where test result bundle could not be found #363

Closed chrisballinger closed 5 years ago

chrisballinger commented 5 years ago

Not the cleanest solution, but I wanted to run this on CI and see if this fix works there as well.

raizlabs-oss-bot commented 5 years ago
2 Messages
:book: Test Results
:book: Code Coverage

Current coverage for BonMot.framework is 81.90%

✅ No files affecting coverage found

Powered by xcov

Generated by :no_entry_sign: Danger

ZevEisenberg commented 5 years ago

@chrisballinger were all the project and scheme changes intentional? We're now three Inception-dream-levels deep into this PR. It goes

master → swift-5 → fastlane-xcov-fix → xcode_10.2_fixes

I'd love to collapse this a little more cleanly, just to keep track of where the various changes belong. If it's too much of a hassle to disentangle things, that's fine, but if it's relatively easy, I'd like to keep the commits small and atomic.

chrisballinger commented 5 years ago

Haha yeah we are a few PR levels deep, but I didn't want to just start adding test commits to the other PRs. I'd also like to see if I can eliminate the duplicate test run before we merge.