Rightpoint / BonMot

Beautiful, easy attributed strings in Swift
MIT License
3.54k stars 196 forks source link

Test cleanup and typo fixes #405

Closed ZevEisenberg closed 3 years ago

ZevEisenberg commented 3 years ago

The only interesting thing (and calling it interesting is probably a stretch) is the commit that fixes a typo in public API by deprecating and renaming it. Please let me know if you think I've done it in a good way, and whether it constitutes a breaking change. (If the latter, we might as well just rename it and skip the deprecation.) It's a tricky case because the renamed parameter has a defaulted value, so consumers may not even be aware that there was a typo.

raizlabs-oss-bot commented 3 years ago
2 Messages
:book: Test Results
:book: Code Coverage

Current coverage for BonMot.framework is 76.73%

Files changed - -
AdaptableTextContainer.swift 41.67% :no_entry_sign:
AdaptiveStyle.swift 75.00% :warning:
StyleableUIElement.swift 76.09% :warning:
NSAttributedString+Adaptive.swift 90.38% :white_check_mark:
XMLBuilder.swift 96.59% :white_check_mark:
FontFeatures.swift 97.83% :white_check_mark:
Composable.swift 98.59% :white_check_mark:
Tab.swift 98.89% :white_check_mark:

Powered by xcov

Generated by :no_entry_sign: Danger