Rightpoint / RZCellSizeManager

Dynamic size computation and caching for cells.
MIT License
242 stars 32 forks source link

Try fix issue with only on class name #28

Open bimawa opened 9 years ago

bimawa commented 9 years ago

Try fix logic based on class name, and change it on nib or reuseIdentifier. Now i can create some classes for other reuseidentifiers. Trouble described this issue

bimawa commented 9 years ago

@KingOfBrian, ^_^ thx for help :dancers:

KingOfBrian commented 9 years ago

Hey @bimawa , thanks for the fix! It looks good in general, but there are a bunch of good style cleanups and some that don't follow our style guide. Any chance you could clean those up? I commented on a bunch, but rather than comment on them all I thought I'd just put a note here:

KingOfBrian commented 9 years ago

Hah, I just realized that much of this code doesn't follow the coding style! I'll merge in tomorrow, if you want to clean it up some that'd be awesome, but I'll take care of it otherwise.

Thanks for the fix!

bimawa commented 9 years ago

@KingOfBrian, ok i fix it style later. It's my accident i use autoformat in my AppCode. I need fix my configuration style formatter. if you have a link to rules of a standard style it will be cool for me.

KingOfBrian commented 9 years ago

Sweet, Thanks!

https://github.com/Raizlabs/Raizlabs-Cocoa-Style

I wish we could find a good auto-formatter to simplify this, but we don't have a good solution at this point. I've never looked at AppCode's formatter though, that's interesting.

bimawa commented 9 years ago

@KingOfBrian wow thx for link! AppCode formatter is very cool tool. If i found a free time - mb - i try create configuration for us :D