search

Rightpoint / RZUtils

Rightpoint Commonly Used Tools
Other
123 stars 22 forks source link

Bugfix/mgorbach/autolayout common ancestor #107

Closed mgorbach closed 10 years ago

mgorbach commented 10 years ago

The commonAncestorForViews: method should be useful in the future as we add more interesting things to this category.

@Raizlabs/maintainers-ios: please review. This PR comes from an issue I found: the rz_pinHeightToView and rz_pinWidthToView methods worked correctly only if the passed-in view was a subview of self.

This is an unnecessary limitation. I've made them significantly more flexible by finding the common ancestor and applying the constraint in the right place.

mgorbach commented 10 years ago

@ndonald2 New PR for you.

mgorbach commented 10 years ago

@Raizlabs/maintainers-ios I've also changed the default branch on this repo to develop.

ndonald2 commented 10 years ago

@mgorbach I'd caution against changing the default branch since this is open-source. If others stumble upon it, it may not be immediately apparent that the default branch is not the stable one.

ndonald2 commented 10 years ago

@ZevEisenberg Not sure if it affects CocoaPods, but I'm pretty sure it does not since specs in the trunk are always based on tags. Either way, OSS repos should never have a dev branch as the default, IMO, if they are intended to be discoverable by the public.

ndonald2 commented 10 years ago

@mgorbach This looks good. Merging and adding to 2.4.0 release candidate.